Modal accessibility content and images

[mbgower]

Rewrite of accessibility content for Modal component

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
carbondesignsystem	✅ Ready (Inspect)	Visit Preview	Dec 20, 2022 at 5:40PM (UTC)

[aagonzales]

It looks good except for a couple of minor content suggestions or questions. Also I noticed you used both the term "dialog" and "modal." Is the use of dialog in some place over modal intentional? This is the modal component so I wonder if we should just stick to modal or be specific and say "modal dialog" instead of just "dialog."

[aagonzales]

Edit to add clarity, I had to read the sentence a couple of times to make sure I understood it correctly. Just a suggestion.

Suggested change

	Design annotations are needed for specific instances shown below, but for the
	standard modal dialog component, Carbon already incorporates accessibility.
	Design annotations are needed for specific instances shown below, except for the
	standard modal dialog component that Carbon already incorporates accessibility.

[mbgower]

@aagonzales That's the stock pre-amble. While I agree it can get improved on, I'm not sure the rewrite improves it enough.
For most components, we're conveying that 'you're all good.' For some, we're trying to convey 1) most of the stuff is taken care of 2) in some (but depending on the component, not all) situations you need to make some design annotations.
I suggest we come back to the pre-amble with fresh eyes after the holidays and do a global update once we get something everyone thinks is an improvement :)

[aagonzales]

Yeah that's fine to come back to this. I think its just the phrasing/sentence structure that is causing confusion for me. It would be great if we could have a content designer review the boilerplate intros and content.

[mbgower]

Is the use of dialog in some place over modal intentional?

@aagonzales This is a widespread challenge. Technically it should always be modal dialog, but of course the Carbon component is just called "modal" (which is fairly common in the industry). It can cause confusion just using modal, especially when we get to non-modal which seems like it can be applied to more than just dialogs. Since we're talking specifically about a kind of dialog, I think it's okay to say "dialog" and I find it flows better in many instances.

I was careful to say "modal dialog" in the first two instances to establish these are essentially synonyms. Then in captions, etc., I went with what is more technically correct, which is "dialog". (I intentionally used 'modal' in the ALTs to complement dialog in the captions.)

[aagonzales]

Alright then i think this is good to go.