-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(fluid): remove "fixed" term #3391
docs(fluid): remove "fixed" term #3391
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Button (Usage tab)
These sections still reference fixed in the heading and places in the body copy.
Date picker, Dropdown, Number input, Search, Select, Text input (Style tab)
There are references to Fixed still throughout these tabs.
Login pattern
These sections still reference fixed in the body copy.
Sorry, It's too complicated to use the Jan method here... Addressing Lauren's comments above for button... this is what I would change: Button changesNote: these are not all consecutive paragraphs, I just addressed the spots where "fixed" was used Question: In general, would it make more sense to use the term "fluid-width default buttons" vs. "hybrid fluid buttons?" Fluid vs. default buttons Fluid components like button never exist in isolation. As you can see in the examples above, they are always part of another component, like modal or form. Other fluid components include tiles and most recently, text inputs. Fluid-width default buttons Fluid-width default buttons are always preferable to fixed-width default buttons in a layout. When possible set the default button container’s relative position to the responsive layout grid and match button width to the width of other elements on the page. Ideally, when using groups of related buttons (not including ghost buttons), they should all be the same width. See button groups below for more detailed information. Stacked button groups Generally, when designers stack buttons, they tend to use the hybrid fluid buttons. However, stacked fluid buttons are also an option in desktop side panels with especially long calls to action. Note: experimenting with stacked fluid buttons would require an override to the existing code. Login changesSeparate authentication methods If distinguishing between the authentication methods in the background is not technically feasible, provide users buttons to the various paths upfront. Consult your product team’s guidance to determine which alternative logins your platform or product offers. Default text inputs and buttons should be used for this design so that the primary button can maintain its position next to the input field. See the Fluid vs. default inputs section below for more specific usage guidance. Also, please refer to brand guidelines when using logos for alternative logins. Examples of brand guidelines for a few commonly used alternative logins include: (Under client-side verification) Whether you are using default or fluid text inputs in your login flow, inline error messages should be displayed below any required field that is empty once the field loses focus or an action button (“Continue” or “Log in”) is clicked. See the fluid text input specs for more information on error states. Once the field is filled, the error message should disappear. Fluid vs. default components Although the fluid inputs have not been added as a variant to Carbon core components yet, they have complete design specs and are currently under development. Since many product teams have expressed interest in using the fluid inputs for Login and Sign up flows, the Carbon team wanted to consolidate exploration and present a clear path forward. What we have presented above is the ideal future state of the login pattern. However, since a coded variant does not exist for fluid inputs, many teams may choose to proceed with the default inputs. Below are several alternate examples illustrating the login flow with default inputs. Fluid buttons and inputs require floating containers, whereas default buttons and inputs can either sit on the page, without a container, or sit in a side-aligned full bleed container (much like a panel). Example of a log in flow using default text input components Designing for multiple alternate logins As mentioned above, we prefer that the system distinguishes the path a user needs to take in the background rather than making them choose in the UI. However, with certain products, that’s not an option. In order to present multiple alternate logins to the user up front, designers must use default text inputs and default buttons so that the primary button can remain close to the input field. Be mindful of the hierarchy and avoid layouts that emphasize alternate logins over the preferred login path. Position Carbon provides best practice advice on the login pattern but will leave more specific design guidance to the product teams. For instance, decisions like where to position the login flow on a page (i.e. left, right, or center), or whether to use fluid or default inputs, can be made at the product team level as long as the fields remain on the grid. Designers can also choose whether to incorporate brand-approved background textures, illustrations and/or marketing content. Visit the IBM Brand Center for specific guidance and approved assets relating to your brand and/or sub-brand. Fluid login form The fluid login form has consistent margins regardless of its width on the grid or whether it uses fluid or default inputs. When the password input appears in place of the username input, all of the spatial relationships remain the same, even though certain options (for example, “Remember ID” and alternate logins) disappear. This prevents an awkward resizing or jumping during the animation. Specs for margins and vertical spacing in a centered login form with default input Default login form The default login form may or may not appear within a container and margins will vary according to its location on the grid. Adhere to the vertical spacing in the specs below regardless of the container. If teams choose not to use “Remember ID” (which is optional), they can simply remove the 24px margin top along with it, to adjust the spacing. Specs for margins and vertical spacing in a split-screen login form with default input |
@laurenmrice Ok updates are made! I did not update image file names so "fixed" may still appear in a search do to that OR on the style tab because of the image component's name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! ⭐️
Update to replace the term "fixed" with "default."
Effected pages