Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update a11y tab with pagination nav variant #4206

Merged
merged 10 commits into from
Aug 23, 2024
Merged

docs: update a11y tab with pagination nav variant #4206

merged 10 commits into from
Aug 23, 2024

Conversation

laurenmrice
Copy link
Member

@laurenmrice laurenmrice commented Aug 19, 2024 •
edited
Loading

Closes #4198

This PR updates the Pagination A11y tab with content and images for the pagination nav variant.

Dev help when reviewing:

  • I would like the dev on this PR to make sure the new information is accurate. I was not sure if the component is actually functioning as intended by keyboard after writing some content for this.
  • Let me know if there is anything I need to add to the "Development considerations" section.

Changelog

New

  • New images on a11y tab
  • New content sections on a11y tab

Removed

  • Removed images we are no longer using.

@vercel Vercel
Copy link

vercel bot commented Aug 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 6:56pm

@laurenmrice laurenmrice self-assigned this Aug 21, 2024
emyarod
emyarod approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@laurenmrice laurenmrice marked this pull request as ready for review August 21, 2024 19:46
@laurenmrice laurenmrice requested review from a team as code owners August 21, 2024 19:46
alisonjoseph
alisonjoseph approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the keyboard interactions and it LGTM!

alina-jacob
alina-jacob approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@alina-jacob alina-jacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@kodiakhq kodiakhq bot merged commit 82d8bff into carbon-design-system:main Aug 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alina-jacob alina-jacob alina-jacob approved these changes

@emyarod emyarod emyarod approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@benjamin-kurien benjamin-kurien Awaiting requested review from benjamin-kurien benjamin-kurien is a code owner automatically assigned from carbon-design-system/design

Assignees

@laurenmrice laurenmrice

Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pagination, Pagination Nav] update content on the Accessibility tab
4 participants
@laurenmrice @alisonjoseph @emyarod @alina-jacob