-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(structured list) feature flag usage, style, code tab update #4258
docs(structured list) feature flag usage, style, code tab update #4258
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…thub.com/laurenmrice/carbon-website into feature-flags-structured-list-doc-update
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@aagonzales Yeah, this part has been really tricky to deal with and I agree it currently looks strange. I will try one of those suggestions out. I think I like the separate H3 section instead of adding a third tab. |
…thub.com/laurenmrice/carbon-website into feature-flags-structured-list-doc-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good! The only thing I saw was on the style tab with the image under With background interactive state color
the tabbed image kind of jumps some when tabbing between them. Not really a blocker though so I'm going to go ahead and approve.
I see it! I am fixing it before it merges in. Thank you! |
Closes #4224
This PR updates the Structured list component Usage, Style, and Code tabs to include feature flag information and images. The content on the Usage and Style tabs have also been updated with the new content templates.
Note: Links in various places to the "Feature Flag tab" have not been updated yet, because that page is not live yet.
Changelog
New
Usage:
Style:
Code:
Changed
Removed