Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken contribution images #4299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: broken contribution images #4299

wants to merge 1 commit into from

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Sep 27, 2024 •
edited
Loading

Closes #4284

Changelog

Changed

  • switch html images to markdown images
  • move class name to container and update styles

@alisonjoseph alisonjoseph requested review from a team as code owners September 27, 2024 17:19
@vercel Vercel
Copy link

vercel bot commented Sep 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 5:32pm

Kritvi-bhatia17
Kritvi-bhatia17 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kritvi-bhatia17 Kritvi-bhatia17 Kritvi-bhatia17 approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@thyhmdo thyhmdo Awaiting requested review from thyhmdo thyhmdo is a code owner automatically assigned from carbon-design-system/design

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs]: Contribution gallery is broken, images don't display
2 participants
@alisonjoseph @Kritvi-bhatia17