Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: title on AI component cards #4300

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

alisonjoseph
Copy link
Member

Closes #4283

Changelog

  • update to correct prop names so title shows up on AI component cards

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:35pm

Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aagonzales, could you please confirm whether the font size here should be 12px to match the Components’ Overview cards, or should it be 14px?

image

@alisonjoseph thanks for fixing this so quickly! Although not directly related to this issue, just wanted to confirm with you—are these ImageCards responsive? 🤔

@alisonjoseph
Copy link
Member Author

alisonjoseph commented Sep 27, 2024

@Kritvi-bhatia17 @aagonzales ah yea they are different font sizes. The AI page is using the ImageCard component from the gatsby theme https://gatsby-theme-carbon.vercel.app/components/ImageCard/ and the component overview page is using a custom component built just for our website.

and yes they should be responsive by default

@aagonzales
Copy link
Member

@Kritvi-bhatia17 @alisonjoseph I think its fine that they are different font sizes since they wont be seen together on the same page. I don't think its worth doing any extra work or customization just for that.

Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks @alisonjoseph & @aagonzales for the confirmation!
LGTM 🚀

@kodiakhq kodiakhq bot merged commit ddda03e into carbon-design-system:main Sep 27, 2024
7 checks passed
@alisonjoseph alisonjoseph deleted the component-names branch September 27, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AI] Component names not displaying on the AI component list cards
4 participants