Skip to content

Commit

Permalink
chore(tooltip): remove aria-hashpopup property in tooltip component (#…
Browse files Browse the repository at this point in the history
…5301)

Co-authored-by: TJ Egan <tw15egan@gmail.com>
  • Loading branch information
xxxle0 and tw15egan authored Feb 7, 2020
1 parent e1c1f22 commit 546eda6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 3 additions & 3 deletions packages/components/src/components/tooltip/tooltip.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<div id="{{noHeading.idSuffix}}-label" class="{{@root.prefix}}--tooltip__label">
Tooltip label
<button aria-expanded="false" aria-labelledby="{{noHeading.idSuffix}}-label" data-tooltip-trigger data-tooltip-target="#{{noHeading.idSuffix}}"
class="{{@root.prefix}}--tooltip__trigger" aria-controls="{{noHeading.idSuffix}}" aria-haspopup="true">
class="{{@root.prefix}}--tooltip__trigger" aria-controls="{{noHeading.idSuffix}}">
{{ carbon-icon 'Information16' }}
</button>
</div>
Expand All @@ -32,7 +32,7 @@
<div id="{{heading.idSuffix}}-label" class="{{@root.prefix}}--tooltip__label">
Tooltip label
<button aria-expanded="false" aria-labelledby="{{heading.idSuffix}}-label" data-tooltip-trigger data-tooltip-target="#{{heading.idSuffix}}"
class="{{@root.prefix}}--tooltip__trigger" aria-controls="{{heading.idSuffix}}" aria-haspopup="true">
class="{{@root.prefix}}--tooltip__trigger" aria-controls="{{heading.idSuffix}}">
{{ carbon-icon 'Information16' }}
</button>
</div>
Expand All @@ -50,7 +50,7 @@
<div id="{{label.idSuffix}}-label" class="{{@root.prefix}}--tooltip__label">
Tooltip label
<div tabindex="0" aria-expanded="false" aria-labelledby="{{label.idSuffix}}-label" data-tooltip-trigger data-tooltip-target="#{{label.idSuffix}}"
role="button" class="{{@root.prefix}}--tooltip__trigger" aria-controls="{{label.idSuffix}}" aria-haspopup="true">
role="button" class="{{@root.prefix}}--tooltip__trigger" aria-controls="{{label.idSuffix}}">
{{ carbon-icon 'Information16' }}
</div>
</div>
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/components/Tooltip/Tooltip.js
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,6 @@ class Tooltip extends Component {
onFocus: this.handleMouse,
onBlur: this.handleMouse,
'aria-controls': !open ? undefined : tooltipId,
'aria-haspopup': 'true',
'aria-expanded': open,
'aria-describedby': open ? tooltipId : null,
// if the user provides property `triggerText`,
Expand Down

0 comments on commit 546eda6

Please sign in to comment.