Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aria-hashpopup tooltip prop #5301

Conversation

xxxle0
Copy link
Contributor

@xxxle0 xxxle0 commented Feb 7, 2020

Closes #5300

  • remove aria-hashpopup prop

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

@xxxle0 xxxle0 requested a review from a team as a code owner February 7, 2020 15:58
@ghost ghost requested review from aledavila and emyarod February 7, 2020 15:59
@netlify
Copy link

netlify bot commented Feb 7, 2020

Deploy preview for carbon-elements failed.

Built with commit cc278d3

https://app.netlify.com/sites/carbon-elements/deploys/5e3dc45a844b0b00080af705

@netlify
Copy link

netlify bot commented Feb 7, 2020

Deploy preview for carbon-components-react failed.

Built with commit cc278d3

https://app.netlify.com/sites/carbon-components-react/deploys/5e3dc45afb32cb0008ef5ad2

@tw15egan tw15egan merged commit 546eda6 into carbon-design-system:master Feb 7, 2020
@carmacleod
Copy link
Contributor

Thank-you @xxxle0 and reviewers!
@tw15egan How can I tell which version of Carbon react this change will be in?

@tw15egan
Copy link
Collaborator

tw15egan commented Feb 7, 2020

Should be included in the next patch release (10.9.4 / 7.9.4) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please remove aria-haspopup="true" from tooltip markup
5 participants