Dropdown: v11 audit

[aagonzales]

Audit

A designer and developer will pair on this audit, some tasks may be discipline focused. Follow the checklist below for the features and items to review. If there are no issues with the item then check the item as complete. If any problems or bugs come up when auditing add a comment to this issue with the problem and how to correct it (if you know how). Bugs do not need to be fixed while auditing.

Resources

• Design spec in Sketch
• V11 Website
• SCSS
• Storybook

Variants

• Default
• Multi-select
• Combo-box

Checklist

Visual (in React code)
Design and dev check

• Component is using the correct design tokens (color and type), see design spec and scss code.
• Component is rendering correctly across themes and layers, see design spec and storybook.
  • White theme
  • Gray 10 theme
  • Gray 90 theme
  • Gray 100 theme
• Component is rendering correctly across browsers (check themes across browsers as well), see storybook.
  • Firefox
  • Safari
  • Chrome
• Component sizes are rendering and named correctly (if applicable)

Website (v11)
Design checks

• Style tab has correct design tokens listed
• Style and usage tabs are using the correct size props names (if applicable)
• Usage tab is up-to-date for with any v11 behavioral changes (if any)
• Live Demo has applied v11 changes
  • Themes are rendering correctly
  • Size props are named correctly
  • No light props included

Design Kits (Sketch only)
Design checks

• Correct design tokens (type and color) are used
• Component using the correct size prop names
• Any additional v11 behaviors have been added

Storybook
Dev checks

• Confirm that prop table is populating
• Take note of missing examples/stories (if any)

React package
Dev checks

• Go to https://codesandbox.io/s/github/carbon-design-system/carbon/tree/main/packages/react/examples/codesandbox and confirm that you can use the component as expected from @carbon/react

Accessibility
Dev checks

• Confirm that there are no violations in Accessibility checker
• Confirm that component works as expected with VoiceOver

Migration docs
Design and dev check

• Any breaking changes to this component are present in the v11 migration guide.
  • Design
  • Develop

[laurenmrice]

Visual bugs

*Note: There is a known color token issue for a few interactive states in the dark themes when you get deeper into the layering model for dropdown/combobox which we are tackling.

scss code

Dropdown

• The label type-style within the field and menu of the dropdown should be type token body-compact-01.

• The dropdown-text type-style is still using a v10 token name. It should be type token body-compact-01.

• The dropdown-list type-style is still using a v10 token name. It should be type token body-compact-01.

• Check to make sure all spacing tokens use the format $spacing- instead of having to prefix the token with $carbon--.

• Is the dropdown-item "active state" actually referring to the selected state? Seems like the background-colorof the selected state and the selected-hover state is currently using the the wrong color.

  • The selected state should be color token $layer-selected.
  • The selected-hover state should be color token $layer-selected-hover.

• dropdown--show-selected background-color should be color token $layer-selected.

.#{$prefix}--dropdown--show-selected .#{$prefix}--dropdown--selected {
display: block;
background-color: $layer-hover;
color: $text-primary;

• Skeleton state: Should be using color token $skeleton-background.
• Double check to make sure sizes are reflected in scss. (Large 48px, Medium 40px, Small 32px). Could not find them in the react story book.

---

Combo box

• Light styles should be marked as deprecated in the scss file.

[laurenmrice]

Design kit

• Update layer styles in menu to use $layer logic for menu in all themes. v11: update sketch libraries with new tokens carbon-design-kit#429

[laurenmrice]

Website

Live demo

*Updating the Live demo with our current code should fix most of these bugs.

• Light modifier needs to be taken off the live demo.
• Needs to display size props
• Needs to display states for invalid and warning.
• The dropdown container should not shrink in width size when a new option is selected if it has a shorter amount of text than the previous selected option.