Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dropdown): fixes based on design audit #10886

Merged
merged 4 commits into from
Mar 4, 2022
Merged

fix(Dropdown): fixes based on design audit #10886

merged 4 commits into from
Mar 4, 2022

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Mar 1, 2022 •
edited by laurenmrice
Loading

Refs #10415
Refs #10596
Refs #10597

Changes tokens based on design audit.

Changelog

Changed

  • Updated tokens for ComboBox, Dropdown, Listbox and Multiselect

Testing / Reviewing

Ensure the following components are rendering correctly and correct tokens are being applied:

  • Combobox
  • Dropdown
  • Listbox
  • Multiselect

@tw15egan tw15egan requested a review from a team as a code owner March 1, 2022 18:11
@netlify
Copy link

netlify bot commented Mar 1, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 72e5c85

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/622234cb7aff9400072b8df1

😎 Browse the preview: https://deploy-preview-10886--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Mar 1, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 72e5c85

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/622234cb54312700081cb089

😎 Browse the preview: https://deploy-preview-10886--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 1, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 72e5c85

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/622234cb63417100087e6c45

😎 Browse the preview: https://deploy-preview-10886--carbon-components-react.netlify.app

laurenmrice
laurenmrice reviewed Mar 3, 2022
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@kodiakhq kodiakhq bot merged commit 1b87683 into carbon-design-system:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@dakahn dakahn dakahn approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tw15egan @joshblack @dakahn @laurenmrice