Number input: v11 audit

[aagonzales]

Audit

A designer and developer will pair on this audit, some tasks may be discipline focused. Follow the checklist below for the features and items to review. If there are no issues with the item then check the item as complete. If any problems or bugs come up when auditing add a comment to this issue with the problem and how to correct it (if you know how). Bugs do not need to be fixed while auditing.

Resources

• Design spec in Sketch
• V11 Website
• SCSS
• Storybook

Checklist

Visual (in React code)
Design and dev check

• Component is using the correct design tokens (color and type), see design spec and scss code.
• Component is rendering correctly across themes and layers, see design spec and storybook.
  • White theme
  • Gray 10 theme
  • Gray 90 theme
  • Gray 100 theme
• Component is rendering correctly across browsers (check themes across browsers as well), see storybook.
  • Firefox
  • Safari
  • Chrome
• Component sizes are rendering and named correctly (if applicable)

Website (v11)
Design checks

• Style tab has correct design tokens listed
• Style and usage tabs are using the correct size props names (if applicable)
• Usage tab is up-to-date for with any v11 behavioral changes (if any)
• Live Demo has applied v11 changes
  • Themes are rendering correctly
  • Size props are named correctly
  • No light props included

Design Kits (Sketch only)
Design checks

• Correct design tokens (type and color) are used
• Component using the correct size prop names
• Any additional v11 behaviors have been added

Storybook
Dev checks

• Confirm that prop table is populating
• Take note of missing examples/stories (if any)

React package
Dev checks

• Go to https://codesandbox.io/s/github/carbon-design-system/carbon/tree/main/packages/react/examples/codesandbox and confirm that you can use the component as expected from @carbon/react

Accessibility
Dev checks

• Confirm that there are no violations in Accessibility checker
• Confirm that component works as expected with VoiceOver

Migration docs
Design and dev check

• Any breaking changes to this component are present in the v11 migration guide.
  • Design
  • Develop

[laurenmrice]

Visual bugs

Scss code

• Number input field type-style should be type token $code-01.
• Check to make sure all spacing tokens use the format $spacing- instead of having to prefix the token with $carbon--.
• Could not find the different sizes that should be available. (large 48px, medium 40px, and small 32px)

Storybook

• Firefox bug: There should be a rule divider between the subtract and add buttons. Another rule divider should appear when the error or warning states are active. Currently it is not showing up.
  

• Could not find the different sizes that should be available. (large 48px, medium 40px, and small 32px)

[laurenmrice]

Website

Style tab

• Color/image: Image needs to be fixed. Number text in the input is the wrong size and misaligned.
  • Add a row for Controls:hover at background field-hover. Also add a *.
• Interactive/error message: Error message should be color token$text-error.
• Interactive: Add rows forwarningstate.

Live demo

• No side panel for modifiers for error and warning states.
• Can't change sizes because they are not available in the side panel.

[laurenmrice]

Design kit

Disabled state

• The rule divider should be color token $border-disabled.

[aledavila]

dev is checked

[tay1orjones]

Closing, live demos will be part of #10889