Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix v11 audit bugs #2750

Merged
merged 8 commits into from
Feb 28, 2022
Merged

docs: fix v11 audit bugs #2750

merged 8 commits into from
Feb 28, 2022

Conversation

laurenmrice
Copy link
Member

@laurenmrice laurenmrice commented Feb 24, 2022 •
edited
Loading

Related #10420, #10418, #10423

Changed
Batch fix for small token bugs I found on the Style tabs in the audit I did for v11 components Loading, Link, and Number input.

Loading
Style tab:

  • Color/small spinner: Background changed to color token layer-accent

Link
Usage tab:

  • Size section: Renamed "Default" link size to "Medium" and fixed image to show the correct one.

Number input
Style tab:

  • Color section/image: Fixed image to correct proportion.
  • interaction states section: Added image.
  • Interactive states section/Error message: Error message was changed to color token $text-error.

@laurenmrice laurenmrice requested review from a team as code owners February 24, 2022 17:01
@vercel
Copy link

vercel bot commented Feb 24, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/EmUm291pftkVEwpejdrB4Nz91Ewa
✅ Preview: https://carbondesignsystem-git-fork-laurenm-b48c1b-carbon-design-system.vercel.app

aagonzales
aagonzales reviewed Feb 25, 2022
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some missing * for layering tokens. looks good otherwise!

src/pages/components/number-input/style.mdx Outdated Show resolved Hide resolved
src/pages/components/loading/style.mdx Outdated Show resolved Hide resolved
@laurenmrice @aagonzales
Update src/pages/components/number-input/style.mdx
bc062b9 
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@laurenmrice @aagonzales
Update src/pages/components/loading/style.mdx
6d8d7cb 
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@kodiakhq kodiakhq bot merged commit 2391324 into carbon-design-system:v11 Feb 28, 2022
@laurenmrice laurenmrice changed the title fix: v11 audit bugs docs: fix v11 audit bugs Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@aagonzales aagonzales aagonzales approved these changes

@joshblack joshblack joshblack approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones is a code owner automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurenmrice @joshblack @aagonzales @dakahn