Select: v11 audit

[aagonzales]

Audit

A designer and developer will pair on this audit, some tasks may be discipline focused. Follow the checklist below for the features and items to review. If there are no issues with the item then check the item as complete. If any problems or bugs come up when auditing add a comment to this issue with the problem and how to correct it (if you know how). Bugs do not need to be fixed while auditing.

Resources

• Design spec in Sketch
• V11 Website
• SCSS
• Storybook

Variants

• Default
• Inline

Checklist

Visual (in React code)
Design and dev check

• Component is using the correct design tokens (color and type), see design spec and scss code.
• Component is rendering correctly across themes and layers, see design spec and storybook.
  • White theme
  • Gray 10 theme
  • Gray 90 theme
  • Gray 100 theme
• Component is rendering correctly across browsers (check themes across browsers as well), see storybook.
  • Firefox
  • Safari
  • Chrome
• Component sizes are rendering and named correctly (if applicable)

Website (v11)
Design checks

• Style tab has correct design tokens listed
• Style and usage tabs are using the correct size props names (if applicable)
• Usage tab is up-to-date for with any v11 behavioral changes (if any)
• Live Demo has applied v11 changes
  • Themes are rendering correctly
  • Size props are named correctly
  • No light props included

Design Kits (Sketch only)
Design checks

• Correct design tokens (type and color) are used
• Component using the correct size prop names
• Any additional v11 behaviors have been added

Storybook
Dev checks

• Confirm that prop table is populating
• Take note of missing examples/stories (if any)

React package
Dev checks

• Go to https://codesandbox.io/s/github/carbon-design-system/carbon/tree/main/packages/react/examples/codesandbox and confirm that you can use the component as expected from @carbon/react

Accessibility
Dev checks

• Confirm that there are no violations in Accessibility checker
• Confirm that component works as expected with VoiceOver

Migration docs
Design and dev check

• Any breaking changes to this component are present in the v11 migration guide.
  • Design
  • Develop

[laurenmrice]

Visual bugs

*Note: There is a known color token issue for a few interactive states in the dark themes when you get deeper into the layering model which we are tackling.

scss

default
select-input

• type-style should be type token $body-compact-01.

• Hover state: background-color should be color token $field-hover.

• Disabled state: background-color should be color token $field.

• Disabled state: border-bottom-color should be transparent.

• Ensure that we are covering the 3 different sizes (Large 48px, Medium 40px, and Small 32px)

• Check to make sure all spacing tokens use the format $spacing- instead of having to prefix the token with $carbon--.

inline
select-inline (select-input)

• Disabled state: background-color should be color token $field.

.#{$prefix}--select--inline .#{$prefix}--select-input[disabled],
.#{$prefix}--select--inline .#{$prefix}--select-input[disabled]:hover {
background-color: $field-disabled;
}

• Disabled state: color should be color token $field.

.#{$prefix}--select--inline .#{$prefix}--select-input:disabled {
color: $disabled;
cursor: not-allowed;

Storybook

• Firefox bug: When the select menu is open, it is hard to read in the dark themes. Is this something we have any control over on our end? Adding a screenshot for reference:

[laurenmrice]

Website

Style tab

• label text color should be $text-secondary.

Live demo

*Updating the Live demo with our current code should fix most of these bugs.

• Variants selector: There should be a variant dropdown selector to select from Default and Inline variants. Inline should not be a knob as a modifier.
• Needs to display size props
• Light modifier needs to be taken off the live demo.
• Need to display warning state as a modifier.
• SelectItemGroup section is showing up as disabled? Should we take this out?

[laurenmrice]

Design kit

• Update layer styles to use $layer logic for menu in all themes. v11: update sketch libraries with new tokens carbon-design-kit#429

[tw15egan]

Changes are up in a PR (#10903) and the rest of the dev checks look good 👍🏻