Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: v11 audit design bugs #2742

Merged

Conversation

laurenmrice
Copy link
Member

@laurenmrice laurenmrice commented Feb 18, 2022

Related: #10410, #10411, #10425, #10430

Changed
Batch fix for small token bugs I found on the Style tabs in the audit I did for v11 components Checkbox, Code snippet, Pagination, and Select.

  • Checkbox: Color section / checkbox:checked checkmark should be$icon-inverse.
  • Code snippet: Color section / Single line variant background should be $layer*.
  • Pagination: Color section / Added a row to specify where to use $text-primary color token.
  • Select: Color section: label text color should be $text-secondary.

@vercel
Copy link

vercel bot commented Feb 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/GaMMzBZwZHV7m7xsbDtZcKVRjzRR
✅ Preview: https://carbondesignsystem-git-fork-laurenm-479572-carbon-design-system.vercel.app

@laurenmrice laurenmrice changed the title V11 audit design bugs fix: v11 audit design bugs Feb 18, 2022
@laurenmrice laurenmrice requested review from aagonzales and removed request for johnbister February 18, 2022 21:09
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurenmrice
Copy link
Member Author

Ready for a dev review when you get a chance @abbeyhrt @aledavila 👀

@kodiakhq kodiakhq bot merged commit 8178dc4 into carbon-design-system:v11 Mar 3, 2022
@laurenmrice laurenmrice deleted the v11-audit-design-bugs branch March 3, 2022 18:21
dakahn pushed a commit to dakahn/carbon-website that referenced this pull request Mar 9, 2022
* fix: checkbox style tab bug

* fix: code snippet style tab bug

* fix: pagiantion style tab bug

* fix: select style tab bug

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
dakahn pushed a commit to dakahn/carbon-website that referenced this pull request Mar 9, 2022
* fix: checkbox style tab bug

* fix: code snippet style tab bug

* fix: pagiantion style tab bug

* fix: select style tab bug

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
joshblack added a commit that referenced this pull request Mar 24, 2022
* docs(motion): update duration token names

* feat(color): update the code page for colos

* fix: v11 audit design bugs (#2742)

* fix: checkbox style tab bug

* fix: code snippet style tab bug

* fix: pagiantion style tab bug

* fix: select style tab bug

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* docs(website): update motion usage docs

* docs(website): add spacing usage docs

* docs(website): update themes usage docs

* docs(Typography): update usage documentation

* fix v11 audit bugs: Progress indicator and Structured list (#2757)

* docs(Motion/Type): update usage documenatation

* docs(Spacing): add linebreak before table

* docs(Motion): add linebreak

* docs(Motion): add manual linebreak

* chore(website): update yarn lock after merge conflicts

* docs(Usage): move line break to own line

Co-authored-by: Josh Black <josh@josh.black>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: DAK <dakahn@users.noreply.github.com>
Co-authored-by: thyhmdo <77697351+thyhmdo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants