Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Search expandable disabled state style error #11780

Closed
2 tasks done
shixiedesign opened this issue Jul 12, 2022 · 0 comments · Fixed by #11782
Closed
2 tasks done

[Bug]: Search expandable disabled state style error #11780

shixiedesign opened this issue Jul 12, 2022 · 0 comments · Fixed by #11782
Assignees
@tw15egan
Labels
type: bug 🐛

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented Jul 12, 2022 •
edited
Loading

Package

@carbon/react

Browser

Chrome

Package version

1.7.0

React version

No response

Description

Search > Expandable variant doesn't have the correct disabled state styling. Although cursor turned into "Not allowed", the color of icon didn't change. Expecting the color of search icon to turn into a lighter gray, maybe $icon-disabled.

Jul-12-2022 21-51-49

Reproduction/example

https://react.carbondesignsystem.com/?path=/story/components-search--expandable&args=disabled:true

Steps to reproduce

  1. Go to https://react.carbondesignsystem.com/?path=/story/components-search--expandable&args=disabled:true
  2. In control panel, set Disabled to True

Code of Conduct
@tw15egan tw15egan self-assigned this Jul 12, 2022
@tw15egan tw15egan mentioned this issue Jul 12, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #11782 Jul 19, 2022
@kodiakhq kodiakhq bot moved this to ✅ Done in Design System Jul 19, 2022
kennylam pushed a commit to kennylam/carbon that referenced this issue Jul 30, 2024
@renovate
chore(deps): update dependency @carbon/icons to v10.48.5 (carbon-desi…
2ac866d 
…gn-system#11780)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@carbon/icons](https://togithub.com/carbon-design-system/carbon) ([source](https://togithub.com/carbon-design-system/carbon/tree/HEAD/packages/icons)) | [`10.48.4` -> `10.48.5`](https://renovatebot.com/diffs/npm/@carbon%2ficons/10.48.4/10.48.5) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@carbon%2ficons/10.48.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@carbon%2ficons/10.48.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@carbon%2ficons/10.48.4/10.48.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@carbon%2ficons/10.48.4/10.48.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>carbon-design-system/carbon (@&carbon-design-system#8203;carbon/icons)</summary>

### [`v10.48.5`](https://togithub.com/carbon-design-system/carbon/compare/4e41819f51f1294d467e12995c217ed83f695249...37eae9c2cd0cf3522e56f8456e99901245ebda85)

[Compare Source](https://togithub.com/carbon-design-system/carbon/compare/4e41819f51f1294d467e12995c217ed83f695249...37eae9c2cd0cf3522e56f8456e99901245ebda85)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/carbon-design-system/carbon-for-ibm-dotcom).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

Labels
type: bug 🐛
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(Search): fix expandable search disabled state tw15egan/carbon
2 participants
@tw15egan @shixiedesign