Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Read-only Inputs]: Epic #12241

Closed
30 tasks done
sstrubberg opened this issue Oct 5, 2022 · 2 comments
Closed
30 tasks done

[Read-only Inputs]: Epic #12241

sstrubberg opened this issue Oct 5, 2022 · 2 comments
Labels
epic Special label used by ZenHub for epic functionality planning: umbrella Umbrella issues, surfaced in Projects views role: design ✏️ role: dev 🤖
Milestone

Comments

@sstrubberg
Copy link
Member

sstrubberg commented Oct 5, 2022

User story

As an IBM Maker:

I need to: build forms that allow Read-only component content to be parsed

so that: my users can more semantically and accessibly mark-up their forms.

Additional information

Acceptance Criteria

Update website docs

  1. role: design ✏️ type: docs 📖 type: enhancement 💡
    laurenmrice
  2. adopter: DSAG adopter: PAL component: checkbox proposal: accepted role: design ✏️ type: docs 📖 version: 11
    laurenmrice
  3. adopter: DSAG adopter: PAL component: date-picker proposal: accepted role: design ✏️ type: docs 📖 version: 11
    laurenmrice
  4. adopter: DSAG adopter: PAL component: time-picker proposal: accepted role: design ✏️ type: docs 📖 version: 11
    laurenmrice
  5. adopter: DSAG adopter: PAL component: dropdown proposal: accepted role: design ✏️ type: docs 📖 version: 11
    laurenmrice
  6. adopter: DSAG adopter: PAL component: number-input proposal: accepted role: design ✏️ type: docs 📖 version: 11
    laurenmrice
  7. adopter: DSAG adopter: PAL component: radio-button proposal: accepted role: design ✏️ type: docs 📖 version: 11
    laurenmrice
  8. adopter: DSAG adopter: PAL component: slider proposal: accepted role: design ✏️ type: docs 📖 version: 11
    laurenmrice
  9. adopter: DSAG adopter: PAL component: text-area proposal: accepted role: design ✏️ type: enhancement 💡 version: 11
    laurenmrice
  10. adopter: DSAG adopter: PAL component: text-area proposal: accepted role: design ✏️ type: docs 📖 version: 11
    laurenmrice
  11. adopter: DSAG adopter: PAL component: toggle proposal: accepted role: design ✏️ status: needs triage 🕵️‍♀️ type: docs 📖 version: 11
    laurenmrice
  12. adopter: DSAG adopter: PAL component: select proposal: accepted role: design ✏️ type: docs 📖 version: 11
    laurenmrice
  13. adopter: DSAG adopter: PAL component: combobox proposal: accepted role: design ✏️ type: docs 📖 version: 11
    laurenmrice
  14. adopter: DSAG adopter: PAL component: multiselect proposal: accepted role: design ✏️ type: docs 📖 version: 11
    laurenmrice

Update design kits

  1. adopter: DSAG adopter: PAL kit: figma role: design ✏️ type: enhancement 💡 version: 11
    laurenmrice thyhmdo
  2. kit: figma role: design ✏️
    thyhmdo

Primary implementation

  1. adopter: DSAG adopter: PAL component: checkbox needs: community contribution package: @carbon/react proposal: accepted type: enhancement 💡 version: 11
  2. adopter: DSAG adopter: PAL component: date-picker needs: community contribution package: @carbon/react proposal: accepted type: enhancement 💡 version: 11
  3. adopter: DSAG adopter: PAL component: time-picker needs: community contribution package: @carbon/react proposal: accepted type: enhancement 💡 version: 11
  4. adopter: DSAG adopter: external component: dropdown needs: community contribution package: @carbon/react proposal: accepted type: enhancement 💡 version: 11
  5. adopter: DSAG adopter: PAL component: number-input needs: community contribution package: @carbon/react proposal: accepted type: enhancement 💡 version: 11
  6. adopter: DSAG adopter: PAL component: radio-button needs: community contribution package: @carbon/react proposal: accepted type: enhancement 💡 version: 11
  7. adopter: DSAG adopter: PAL component: slider needs: community contribution package: @carbon/react proposal: accepted type: enhancement 💡 version: 11
  8. status: ready to merge 🎉
  9. adopter: DSAG adopter: PAL component: toggle needs: community contribution package: @carbon/react proposal: accepted type: enhancement 💡 version: 11
  10. adopter: DSAG adopter: PAL component: select needs: community contribution package: @carbon/react proposal: accepted type: enhancement 💡 version: 11
  11. adopter: DSAG adopter: PAL component: combobox needs: community contribution package: @carbon/react proposal: accepted type: enhancement 💡 version: 11
  12. adopter: DSAG adopter: PAL component: multiselect needs: community contribution package: @carbon/react proposal: accepted type: enhancement 💡 version: 11
  13. status: ready to merge 🎉
  14. role: dev 🤖 type: enhancement 💡 version: 11
    tw15egan
@sstrubberg sstrubberg added epic Special label used by ZenHub for epic functionality planning: umbrella Umbrella issues, surfaced in Projects views labels Oct 5, 2022
@sstrubberg sstrubberg added this to the 2022 Q4 milestone Oct 5, 2022
@sstrubberg sstrubberg changed the title [Read-only Input Components]: Epic [Read-only Inputs]: Epic Oct 6, 2022
@sstrubberg sstrubberg added the needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. label Oct 6, 2022
@lee-chase
Copy link
Member

Need to consider the various dropdown flavours (not a normal form component) and Select.

@lee-chase
Copy link
Member

OK. So straw men are all created @sstrubberg

@tay1orjones the only outstanding issue you raised (unless I've missed some) is the property name readOnly. Before I started this work the TextInput and NumberInput components already had a property readOnly. I replicated this for consistency, however, like you I would prefer readonly as we are adhering to the pattern of this standard attribute. I could update all to have a readonly property, mark readOnly as deprecated in TextInput and NumberInput while treating it as readonly if a readonly property is not supplied.

@aagonzales has raised a question regarding cursors. Ordinarily, an 'input' does not change the text cursor when read-only. We have extended the concept beyond textual input boxes to checkboxes, radio buttons and a number of other scenarios which have buttons displayed but disabled. I think this requires a sync up with the read-only pattern designers to discuss. I'll suggest they organise something.

@sstrubberg sstrubberg added role: dev 🤖 role: design ✏️ and removed type: enhancement 💡 proposal: accepted This request has gone through triaging and we are accepting PR's against it. package: @carbon/react @carbon/react needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. adopter: PAL Work-stream that directly helps a Pattern & Asset Library. adopter: DSAG labels Nov 16, 2022
@tay1orjones tay1orjones removed this from the 2022 Q4 milestone Jan 24, 2023
@tay1orjones tay1orjones added this to the 2023 Q1 milestone Jan 24, 2023
@sstrubberg sstrubberg modified the milestones: 2023 Q1, 2023 Q2 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Special label used by ZenHub for epic functionality planning: umbrella Umbrella issues, surfaced in Projects views role: design ✏️ role: dev 🤖
Projects
Archived in project
Archived in project
Development

No branches or pull requests

3 participants