-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE]: Read only rollup #12601
Conversation
Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@lee-chase what did you want to do with this one? Should these changes be merged or marked ready for review? |
@sstrubberg just nudged me via Slack. I had intended it as a demo, but when it was discussed I believe Scott or yourself indicated it would be a good idea to keep some of this and simplify how it is built. I believe we thought it nice to keep the 'All' page could discard the rest. I can certainly update to do that. One open question would be as to where in the storybook this is placed, it is currently sitting under the |
@lee-chase I think the value derived from the Besides that, the I do believe that we should resurrect this once we have a way to add stories that are included for development purposes only, #12971. I'd love to see the |
This relates to #12241
Added this to enable reviewers to get an understanding of the full set of read-only components
Changelog
New
Added a new story `Experimental/ReadOnlyComparrisons
Testing / Reviewing
Checked to story works locally.