Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ListBoxSelection in favor of new next/ListBoxSelection #12863

Open
4 tasks
Tracked by #6177
, #15803
...
tay1orjones opened this issue Dec 14, 2022 · 1 comment
Open
4 tasks
Tracked by #6177
, #15803
...

Remove ListBoxSelection in favor of new next/ListBoxSelection #12863

tay1orjones opened this issue Dec 14, 2022 · 1 comment
Labels
component: multiselect proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: a11y ♿ type: enhancement 💡 version: 12 Issues pertaining to a future major release of Carbon

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Dec 14, 2022 •
edited
Loading

This issue is for refactoring all usages of the legacy ListBoxSelection to be updated to use next/ListBoxSelection.

A new reimplementation of ListBoxSelection was added in #7777 in next/ListBoxSelection. At that time, ComboBox was updated to use the new implementation. Another component and a series of tests were left using the legacy ListBoxSelection and have not been updated.

Attempting to move these out of next (#12588) caused tests to fail for MultiSelect (#12837). Having our tests fail due to this change points to the potential of this being a breaking change. Consumers relying on/testing the tab order of legacy ListBoxSelection via MultiSelect will have one less tab stop with the new implementation. This would break tests in downstream applications without a major version bump.

#12863 (comment)
@tay1orjones tay1orjones changed the title Remove ListBox.Selection in favor of new next/ListBoxSelection Remove ListBoxSelection in favor of new next/ListBoxSelection Dec 14, 2022
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Dec 14, 2022
@tay1orjones tay1orjones added version: 12 Issues pertaining to a future major release of Carbon type: a11y ♿ labels Dec 14, 2022
@tay1orjones
Copy link
Member Author

Worth noting that this is not a super pressing issue and only results in slightly inferior accessibility within MultiSelect. I've categorized it as an a11y enhancement.

@tay1orjones tay1orjones added type: enhancement 💡 proposal: accepted This request has gone through triaging and we are accepting PR's against it. labels Dec 14, 2022
@tay1orjones tay1orjones moved this to Triage in Roadmap Dec 14, 2022
@tay1orjones tay1orjones moved this from Triage to Accepted in Roadmap Dec 14, 2022
@sstrubberg sstrubberg moved this from ⏱ Backlog to 🕵️‍♀️ Triage in Design System Dec 14, 2022
@sstrubberg sstrubberg moved this from Accepted to Triage in Roadmap Dec 14, 2022
@tay1orjones tay1orjones mentioned this issue Jan 4, 2023
Closed
@sstrubberg sstrubberg moved this from Triage to Icebox in Roadmap Jan 10, 2023
@tay1orjones tay1orjones mentioned this issue Jan 24, 2023
Open
@sstrubberg sstrubberg mentioned this issue Feb 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: multiselect proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: a11y ♿ type: enhancement 💡 version: 12 Issues pertaining to a future major release of Carbon
Projects
Roadmap
Status: Later 🧊
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tay1orjones