-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All fields and inputs] Helper text update #2329
Comments
From an a11y side of things moving the helper text would mean that the Or even easier, using Flexbox's order property. Here's a screen shot from one of my team member's playing around with the component. |
Thanks for this input @elizabethsjudd! Just to clarify, do you see this as an impediment to making this change? Or is this just an added bullet point for the devs to tackle? |
@jeanservaas simply something for the devs to tackle while implementing the change. It shouldn't block the update. |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
As there's been no activity since this issue was marked as stale, we are auto-closing it. |
THIS IS NOT STALE |
As there's been no activity since this issue was marked as stale, we are auto-closing it. |
Palette work in progress. |
Blocked by #3226 |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
not stale |
Keep open to wait for palette work |
It looks like you're going this way anyway, but, if not, here is a rationale. To match users' cognitive flow and prevent user input errors, it would be helpful to retain your original design: Label, helper text, input field, error message. That way, users read the label, then the helper text, then make a valid entry. As you do now, displaying the helper text in italics might be a nice way to differentiate the helper text from the label. |
Closing this issue to start a new one to track implementation of color palette solution. See #3961 |
Enhancement[All input fields]: Helper text update
Jan Child, the Design Lead for Watson assistant made several really good points about the way we're treating helper text followed by these suggestions...
This issue relates to all of our input fields (i.e. text input, text area, number input, select and dropdown components); it also affects the $helper-text type token (which would eventually need to be deprecated).
Move helper text below the input / dropdown fieldEdit based on thread: doesn't work coz dropdown opens and covers helper text.In the instance of an error state, remove helper text in favor of error messageEdit based on thread: no longer relevant if we don't move text down.Designs:
Current state of helper text in context:
Proposed change:
The text was updated successfully, but these errors were encountered: