Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution: Noneditable User Interface Elements #3125

Closed
shixiedesign opened this issue Jun 20, 2019 · 16 comments
Closed

Contribution: Noneditable User Interface Elements #3125

shixiedesign opened this issue Jun 20, 2019 · 16 comments
Labels
hacktoberfest See https://hacktoberfest.com/ package: components carbon-components proposal: not pursuing This has gone through triaging and because of priorities or mission, we will not be pursuing this. role: dev 🤖 status: help wanted 👐

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented Jun 20, 2019

@kaylarakower commented on Thu May 23 2019

Name: Noneditable User Interface Elements

Research: Users of the Enterprise CMS have a form that authors edit and approvers review. Approvers should not be able to edit the form, but need to review for errors and return to the editor to revised as needed. I was directed by Tom Dayton to Sun Web Application, 6.8.1 Noneditable User Interface Elements, which describes this exact use case.

Images: https://ibm.box.com/s/172j35uz1f0ulclf4x3l7vl508apenvy
Sketch file: https://ibm.box.com/s/wfjtwupcp4fcazuplwuzbn871ebx1qeh

Contributing team: DrupalOne
Contributing designer: Kayla Rakower, kayla.rakower@ibm.com
Contributing developer: Chris Wilson, ccwilson@us.ibm.com

image

image


@designertyler commented on Wed Jun 19 2019

Hi @kaylarakower thanks for submitting!

There's a PR open right now to include a read-only state for the text field. Would these specs work for your needs? #3018


@kaylarakower commented on Wed Jun 19 2019

@designertyler This design was created for a slightly use case as none of the fields would be editable, so there is a different state for the accordion as well which I do not believe is covered in #3018. Added a link to this design to that ticket.


@shixiedesign commented on Thu Jun 20 2019

This feels like a larger component – should we add an alternative form variant? @designertyler @aagonzales This layout could be useful in some situations (probably more common in digital/editorial).

If yes, then there has to be different inputs styling.

This is an enhancement category issue though. We will evaluate in more detail next month. Will transfer issue to main carbon repo. Thanks!

@aagonzales
Copy link
Member

aagonzales commented Jun 20, 2019

@kaylarakower this looks very similar to a structure list, how is it different? If its non-editable, is there also an editable version?

@kaylarakower
Copy link

kaylarakower commented Jun 21, 2019

@aagonzales correct, it is almost the same as the structure list. The only additional visual feature is the headline, which in the editable form, is the accordion.

The major difference is the relationship between the editable form and the list. In this screen, please refer to the text describing the scenarios to how the content is translated from the editable form to the read-only form. This was taken directly from the sun web application guidelines.

Depending on the state of the form and/or user access, editing is enabled.

@aagonzales
Copy link
Member

aagonzales commented Jun 21, 2019

@kaylarakower I don't have permissions to view to the images in box. And the "editing is enabled" link didn't take me anywhere.

I think it might help us in the future if you share all these things in the issue itself so we're not having to jump around to different places. You can make selective editing choices for confidential content on screens if need be.

@kaylarakower
Copy link

@aagonzales the links are set to be visible to anyone within the enterprise. Unfortunately I cannot share the links directly or change the permissions as they would reveal information pertaining to an internal product. I am happy to elaborate when we chat next week.

@aagonzales
Copy link
Member

aagonzales commented Jun 21, 2019

@kaylarakower oh I figured it out, you can't place box links with permission in the a [](url) syntax. Only the direct link will work, I had to "edit" view your comment to get the real link.

The editing is enable link is still broken doing that as well. Looks like it might to be the page url instead of the shared link from box.

@shixiedesign
Copy link
Contributor Author

I just posted a screenshot of the sketch-file in issue description for those who can't download the files.

@kaylarakower
Copy link

Spoke to @aagonzales today and I will work on developing this concept further to better align with the editable state.

@aagonzales
Copy link
Member

aagonzales commented Jul 22, 2019

✅ Experimental status approved

Moving forward this component will go into experimental to start with. I have approved @kaylarakower latest designs. Her developers will be building and contributing this component.

@kaylarakower
Copy link

kaylarakower commented Jul 22, 2019

Changed title of contribution to "Form Summary"

@kaylarakower
Copy link

kaylarakower commented Jul 22, 2019

Updated sketch file: https://ibm.box.com/s/rl5gwdxkf0jirnv78zsb5klqqyioay59

Form Summary pattern

@kaylarakower
Copy link

Logic:

  1. IF a form has 2 columns AND one field is left blank, the field takes up the full width.
  2. IF 1 field is left blank AND there is no field to the left/right of it, THEN the field below moves up as if it wasn't there.
  3. IF a form has 2 columns AND one field is left blank AND the other field to the left/right is left blank, then THEN the field below moves up as if it wasn't there.

@kaylarakower
Copy link

Update: My team will not be able to contribute the development of this feature, @aagonzales please add to dev backlog

@stale
Copy link

stale bot commented Aug 30, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Aug 30, 2019
@stale
Copy link

stale bot commented Sep 2, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed Sep 2, 2019
@aagonzales aagonzales reopened this Sep 25, 2019
@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Sep 25, 2019
@stale
Copy link

stale bot commented Nov 3, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Nov 3, 2019
@asudoh asudoh removed the status: inactive Will close if there's no further activity within a given time label Nov 4, 2019
@joshblack joshblack added proposal: open This request has gone through triaging. We're determining whether we take this on or not. and removed type: enhancement 💡 labels Jan 13, 2020
@alisonjoseph alisonjoseph added proposal: accepted This request has gone through triaging and we are accepting PR's against it. and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Mar 6, 2020
@tw15egan tw15egan added hacktoberfest See https://hacktoberfest.com/ and removed hacktoberfest See https://hacktoberfest.com/ labels Sep 29, 2020
@tay1orjones tay1orjones moved this to Accepted in Roadmap Aug 24, 2022
@sstrubberg
Copy link
Member

Closing in favor of the Read-only Inputs proposal.
#3125

@sstrubberg sstrubberg closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2022
Repository owner moved this from Accepted to Not pursuing in Roadmap Oct 12, 2022
@sstrubberg sstrubberg added proposal: not pursuing This has gone through triaging and because of priorities or mission, we will not be pursuing this. and removed proposal: accepted This request has gone through triaging and we are accepting PR's against it. labels Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest See https://hacktoberfest.com/ package: components carbon-components proposal: not pursuing This has gone through triaging and because of priorities or mission, we will not be pursuing this. role: dev 🤖 status: help wanted 👐
Projects
Archived in project
Archived in project
Development

No branches or pull requests

9 participants