Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data table] Multiple styling bugs #3210

Closed
shixiedesign opened this issue Jun 27, 2019 · 2 comments
Closed

[Data table] Multiple styling bugs #3210

shixiedesign opened this issue Jun 27, 2019 · 2 comments

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented Jun 27, 2019

All themes

1. Header row has extra border bottom. No border until the row immediately underneath header is selected.

image

2. Zebra row has wrong color

Correct zebra row background colors are:
Odd row background: $field-01 at 40% opacity
Even row background: $field-01

Current

image

Current dark theme zebra is all row colors wrong ⚠️

image
image

Should be
image

Dark themes only

1. Overflow menu hover background wrong

Should be using token $hover-selected-ui which is gray 70 hover in G90 theme

White theme Gray 10 theme Gray 90 theme Gray 100 theme
gray-20 hover #cacaca gray-20 hover #cacaca gray-70 hover #656565 gray-80 hover #4c4c4c

Current:

image

Should be:

image

image

2. Overflow menu not using correct theme

For token spec, reference : #3213

Current:

image

Should be:

image

3. Setting (dependent on overflow?) menu is not getting the token assignment too

image

@asudoh
Copy link
Contributor

asudoh commented Oct 29, 2019

  1. The latest master has border on header row removed unless sticky header feature is enabled
  2. Updating zebra color requires component-specific theme token (CC @emyarod), applying alpha channel to theme token (CSS custom properties) is hacky
  3. fix(overflow-menu): update trigger's hover color #4270 fixes the color of overflow menu's trigger button and chore(devenv): apply theme custom properties to floating menus #3444 fixes the color of overflow menu body

@aagonzales Wrt 1. does it (the current behavior in master) sound good? Wrt 2., should we track the issue separately? Thanks!

@tw15egan
Copy link
Collaborator

Closing this as most of the issues have been fixed, and the zebra style fixes are being tracked in #3143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants