-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data table] Multiple styling bugs #3210
Labels
Comments
@aagonzales Wrt 1. does it (the current behavior in |
Closing this as most of the issues have been fixed, and the zebra style fixes are being tracked in #3143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All themes
1. Header row has extra border bottom. No border until the row immediately underneath header is selected.
2. Zebra row has wrong color
Correct zebra row background colors are:
Odd row background:
$field-01
at 40% opacityEven row background:
$field-01
Current
Current dark theme zebra is all row colors wrong⚠️
Should be
Dark themes only
1. Overflow menu hover background wrong
Should be using token
$hover-selected-ui
which is gray 70 hover in G90 theme#cacaca
#cacaca
#656565
#4c4c4c
Current:
Should be:
2. Overflow menu not using correct theme
For token spec, reference : #3213
Current:
Should be:
3. Setting (dependent on overflow?) menu is not getting the token assignment too
The text was updated successfully, but these errors were encountered: