Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: Add more ARIA attributes #4968

Closed
asudoh opened this issue Jan 7, 2020 · 0 comments · Fixed by #4970
Closed

Tabs: Add more ARIA attributes #4968

asudoh opened this issue Jan 7, 2020 · 0 comments · Fixed by #4970

Comments

@asudoh
Copy link
Contributor

asudoh commented Jan 7, 2020

From @abbeyhrt at #4959:

This looks great! Following WAI-ARIA's tabs example and to make the VO more clear, could you add the role of tabpanel to the TabContent?

Also from @abbeyhrt at #4959:

I'm not sure how complicated this would be with how the tabs are, but it would be awesome if we could create a relationship between the Tab and the TabContent with something like aria-controls={tabContentId} on the Tab and aria-labelledBy={TabId} on the TabContent. That seems to be the pattern used on accessible Tabs component examples, https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-2/tabs.html
@asudoh asudoh mentioned this issue Jan 7, 2020
Closed
asudoh added a commit to asudoh/carbon-components that referenced this issue Jan 8, 2020
@asudoh
fix(Tabs): add ARIA attributes
26fcb3b 
This change adds ARIA attributes to `<Tab>` and `<TabContent>` to
better describe their relationship.

Fixes carbon-design-system#4968.
@asudoh asudoh mentioned this issue Jan 8, 2020
Merged
@abbeyhrt abbeyhrt assigned abbeyhrt and unassigned abbeyhrt Jan 8, 2020
asudoh added a commit that referenced this issue Jan 16, 2020
@asudoh
fix(Tabs): add ARIA attributes (#4970)
ead363d 
This change adds ARIA attributes to `<Tab>` and `<TabContent>` to
better describe their relationship.

Fixes #4968.
joshblack pushed a commit to joshblack/carbon that referenced this issue Jan 23, 2020
@asudoh @joshblack
fix(Tabs): add ARIA attributes (carbon-design-system#4970)
0add8cc 
This change adds ARIA attributes to `<Tab>` and `<TabContent>` to
better describe their relationship.

Fixes carbon-design-system#4968.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Tabs): add ARIA attributes asudoh/carbon-components
2 participants
@asudoh @abbeyhrt