Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tag] - needs default type for carbon website component demo #5506

Closed
jnm2377 opened this issue Mar 2, 2020 · 4 comments · Fixed by #5677
Closed

[Tag] - needs default type for carbon website component demo #5506

jnm2377 opened this issue Mar 2, 2020 · 4 comments · Fixed by #5677

Comments

@jnm2377
Copy link
Contributor

jnm2377 commented Mar 2, 2020

If we hard code a specified type, it won't change colors when you select the other knobs. However, if we don't specify a type, it starts off with no color at all until you select a type because it doesn't have a default type. We need a default type for the demo to work correctly.

no default type

Screen Shot 2020-03-02 at 12 28 34 PM

only shows the bg color once you select a type

Screen Shot 2020-03-02 at 12 28 42 PM

@asudoh
Copy link
Contributor

asudoh commented Mar 3, 2020

@emyarod Thoughts...? Thanks!

@emyarod
Copy link
Member

emyarod commented Mar 3, 2020

@asudoh I think we have a couple of options. we can add default prop type setting to the website knob container similar to storybook (this may be a major change), we can style the "typeless" tag (since the prop is not currently required), or we set a default type value in the core library. if we end up adding "typeless" tag styles or changing the default prop type in the core lib we will need input from design to decide which value should be the default

@asudoh
Copy link
Contributor

asudoh commented Mar 4, 2020

Thanks @emyarod for your thoughts.

we set a default type value in the core library

I think this makes the most sense.

@carbon-design-system/design - Any thoughts on the default tag style (type)?

@joshblack joshblack mentioned this issue Mar 5, 2020
82 tasks
@alisonjoseph
Copy link
Member

from Lauren -

If we needed a default tag, I think it would be the gray tag. Since that is what we are basing our themes off of.

asudoh added a commit to asudoh/carbon-components that referenced this issue Mar 23, 2020
This change defines the default tag style (color) as specified in

Fixes carbon-design-system#5506.
asudoh added a commit that referenced this issue Mar 23, 2020
This change defines the default tag style (color) as specified in #5506.

Fixes #5506.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants