-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tag] - needs default type for carbon website component demo #5506
Comments
@emyarod Thoughts...? Thanks! |
@asudoh I think we have a couple of options. we can add default prop type setting to the website knob container similar to storybook (this may be a major change), we can style the "typeless" tag (since the prop is not currently required), or we set a default type value in the core library. if we end up adding "typeless" tag styles or changing the default prop type in the core lib we will need input from design to decide which value should be the default |
Thanks @emyarod for your thoughts.
I think this makes the most sense. @carbon-design-system/design - Any thoughts on the default tag style (type)? |
from Lauren -
|
This change defines the default tag style (color) as specified in Fixes carbon-design-system#5506.
If we hard code a specified type, it won't change colors when you select the other knobs. However, if we don't specify a type, it starts off with no color at all until you select a type because it doesn't have a default type. We need a default type for the demo to work correctly.
no default type
only shows the bg color once you select a type
The text was updated successfully, but these errors were encountered: