-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide useNotification hook #8405
Comments
A few additional opportunities to look into with this:
|
Here’s a rough pass on how multiple inline notifications could stack and be dismissed. I kept it simple for now to make sure we like the overall mechanics. @mjabbink @jeanservaas @tay1orjones Let me know if you have any feedback I should take into the next pass. Thanks! notification-stack.mp4 |
I’m hoping to get some design feedback before moving forward. Let me know if you have any thoughts @jeanservaas @kingtraceyj We might want to limit how many notifications are visible in the stack at a time. We could accomplish this by some kind of gradient on the maximum oldest notification being displayed. As newer notifications are dismissed, older ones become visible. STACK.HIDDEN.mp4Also, for any notifications that timeout by default (might be more relevant to the toast notifications) we could show the user that this notification will dismiss automatically by using the thick stroke on the left as a timer. NOTIFICATION.TIMEOUT.mp4 |
I mentioned before but I did not her a response. The toolbar and button above the accordion rows also be the same height as the accordion rows? That is at least what the primary intent should be. |
Thanks Mike. Yes, the data table should have the 48px toolbar. This was just from an example I found in sketch to help explore how multiple notifications interact. I can make the toolbar change if it's too distracting, but I'm focused on tackling the notification issue. |
I like the updates you've done. I think the fade gradient can work and wonder what @jeanservaas thinks on the details of the gradient? I like the addition of a taller notification in the stack to see what that looks like I also think timeout bar is cool. |
Just a quick update: We removed
|
An additional requirement for this is that it would ideally respect the user's |
Any thoughts of when this will be available for use, even in a pre-release version? Note that I cannot see the code. Thank you for the amazing work! |
Hi @dstran I'm working on this, should have some initial code for carbon team to review soon |
We offer a variety of notification styles but unfortunately leave much of the animation and logic around display notifications to the end-user. We would like to codify this behavior/logic into a single hook,
useNotification
, that would encapsulate this behavior and make it easier for product teams to display/render notifications in their UI. This may look like:Packages impacted
@carbon/react
Acceptance Criteria
#8405 (comment)
The text was updated successfully, but these errors were encountered: