Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SideNavMenu]: regression SideNavMenu no longer collapses in isRail mode when SideNav is not expanded #9725

Closed
2 tasks done
kevinsperrine opened this issue Sep 23, 2021 · 2 comments · Fixed by #9976
Closed
2 tasks done
Assignees
Labels
component: ui-shell package: react carbon-components-react severity: 2 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@kevinsperrine
Copy link
Contributor

Package

carbon-components, carbon-components-react

Browser

Chrome

Package version

v10.44.0, v7.44.0

Description

The expected behavior is for the SideNavMenu item to collapse when the SideNav collapses, and it was fixed at one point: https://deploy-preview-3626--carbon-components-react.netlify.app/?path=/story/ui-shell--sidenav-rail, but there has been a regression and it no longer closes. Also visible in the current storybook: https://react.carbondesignsystem.com/?path=/story/components-ui-shell--side-nav-rail

CodeSandbox example

https://codesandbox.io/s/peaceful-pare-fbo9u?file=/src/index.js

Steps to reproduce

Click the a SideNavMenu item to expand it, move mouse after from SideNav to cause it to collapse into rail mode. Extra space is still visible where submenu items are.

Code of Conduct

@kevinsperrine
Copy link
Contributor Author

We need to re-open this issue. @dakahn The fix works great in dev, but once the code is minified for production the type name is mangled and the check no longer works. See this deploy preview which includes 7.47.2. It works locally, but fails in the preview.

@kevinsperrine
Copy link
Contributor Author

I believe related to this issue. Proposed solution: facebook/react#4915 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ui-shell package: react carbon-components-react severity: 2 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants