fix(UIShell): expand check so side nav items close properly #9976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 2eb313b 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/617c0f779593f100073e2408 😎 Browse the preview: https://deploy-preview-9976--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 2eb313b 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/617c0f773f8f2d00075e0fed 😎 Browse the preview: https://deploy-preview-9976--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 2eb313b 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/617c0f7753dadb0008221e64 😎 Browse the preview: https://deploy-preview-9976--carbon-components-react.netlify.app |
joshblack
approved these changes
Oct 28, 2021
aledavila
approved these changes
Oct 28, 2021
Closed
2 tasks
Closed
tay1orjones
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Nov 4, 2021
…esign-system#9976) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kennylam
added a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
* chore(cwc): generate cwc internal vendor package (carbon-design-system#9953) [carbon-web-components]: updating build scripts to use internal vendor packages carbon-design-system#9763 This PR adds the the gulp tasks to build cwc to the internal vendor folder and changes the paths in web-components to reference the internal files instead. **New** - add to the gulp tasks in `web-components` to build out the `carbon-web-components` internal vendor package **Changed** - change paths to reference the internal `carbon-web-components` vendor files instead <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> * fix(issue-template): add cwc option (carbon-design-system#9967) * chore(lit): upgrading to v2 (carbon-design-system#9905) * chore(lit): update lit imports * chore(lit): upgrading package json * chore(lit): upgraded cwc to v2 * chore(lit): ensure cwc builds * chore(lit): replace ifNonNull with ifDefined * chore(lit): wc storybook starts now * chore(lit): fixed small rendering errors * chore(lit): bring back some changes * fix(lit): couple things added * chore(lit): uploaded upgraded packages to npm * chore(deps): update yarn offline mirror * chore(deps): fixed storybook again * chore(deps): updating yarn offline mirror again * fix(ci): ensured e2e tests pass * fix(copy): ensured things dont double render * fix(leadspace): remove unneeded imports * chore(deps): updated to lit 2.6.0 Co-authored-by: Kenny Lam <kennylam@proton.me> * chore(lit): fix deps paths * chore(prettier): format code * chore(prettier): update ignore file * chore(ci): update paths * chore(storybook): update icon path --------- Co-authored-by: Anna Wen <54281166+annawen1@users.noreply.github.com> Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com> Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9725
displayNamewasn't cutting it when we check for side nav items to pass theisSideNavExpandedattribute onto. So this PR expands that check to also look for just a reagular ol function name 👍🏾Testing / Reviewing