-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Token "field-disabled" not involved into layering model #9832
Comments
cc @aagonzales just wanted to check-in if this was something that we missed when implementing the layer sets or if there is something else going on here 👀 |
Same for placeholder. |
For the field-disabled colors we've actually decided to not add those into the layer sets and we're actually going to remove But you are right is we kept a distinct token for disabled field then we would need one for all three sets. |
Also you are right, looks like we need to update some of the text tokens in the dark themes G90 updates
G100 updates
|
Re-opening issue as all concerns weren't addressed. To-dos:
Consequences: Components that were using these tokens and will need to be updated:
|
Package
@carbon/colors
Browser
No response
Package version
v11 beta 2
Description
For example, we have a theme gray10, there is a white card (layering model). So disabled field is white on white background.
Looks like there should be filed-disabled-01, -02, -03.
CodeSandbox example
—
Steps to reproduce
check https://github.com/carbon-design-system/carbon/blob/36a6fdc307/packages/themes/src/next/g10.js
Code of Conduct
The text was updated successfully, but these errors were encountered: