Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): change placeholder and helper text colors dark themes #9987

Merged
merged 4 commits into from
Oct 29, 2021
Merged

feat(themes): change placeholder and helper text colors dark themes #9987

merged 4 commits into from
Oct 29, 2021

Conversation

aledavila
Copy link
Contributor

@aledavila aledavila commented Oct 28, 2021

Closes #9860
Closes #9832

New colors for $text-placeholder and $text-helper in themes g90 and g100
The decision was made not to add them to the layer sets and just change the global token color

Changelog

Changed

g90

  • changed $text-placeholder from Gray 60 to Gray 50
  • changed $text-helper from Gray 50 to Gray 30

g100

  • changed $text-helper from Gray 50 to Gray 40

@joshblack
Copy link
Contributor

@aagonzales @aledavila are there any component implications for this change or does the value change here cover everything? 👀

@aagonzales
Copy link
Member

It should cover everything. To my knowledge placeholder text is only used in inputs. Placeholder text also never passes color contrast so the fact that it does vary across layers is a moot point from the start.

image

@aledavila
Copy link
Contributor Author

aledavila commented Oct 28, 2021

@joshblack should cover everything since like anna said we only need to make them a bit more visible so they don't match the input color. Helper text as well

@netlify
Copy link

netlify bot commented Oct 28, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: a09e621

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/617c454e37c15b00078ed1f6

😎 Browse the preview: https://deploy-preview-9987--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Oct 28, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: a09e621

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/617c454e09aedc00081d0207

😎 Browse the preview: https://deploy-preview-9987--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 28, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: a09e621

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/617c454e3f8f2d000763e72c

😎 Browse the preview: https://deploy-preview-9987--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit adebf80 into carbon-design-system:main Oct 29, 2021
@Eugeno
Copy link

Eugeno commented Oct 30, 2021

You've made placeholder visible, but what about textDisabled? =)
Same story: gray100 theme, field-03, gray60 text on the gray60 background.

@aagonzales
Copy link
Member

@Eugeno I address that in this issue here: #10054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants