Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(OverflowMenuItem): refactored to functional component #10147

Merged
merged 6 commits into from
Nov 30, 2021
Merged

chore(OverflowMenuItem): refactored to functional component #10147

merged 6 commits into from
Nov 30, 2021

Conversation

sstrubberg
Copy link
Member

REF #10022

@netlify
Copy link

netlify bot commented Nov 19, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: c836610

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61a688d29219db000834a609

😎 Browse the preview: https://deploy-preview-10147--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Nov 19, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: c836610

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61a688d20cbc640008dc942d

😎 Browse the preview: https://deploy-preview-10147--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Nov 19, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: c836610

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61a688d20f6fdc0008ee8674

😎 Browse the preview: https://deploy-preview-10147--carbon-elements.netlify.app

@sstrubberg sstrubberg marked this pull request as ready for review November 29, 2021 21:34
@sstrubberg sstrubberg requested a review from a team as a code owner November 29, 2021 21:34
@abbeyhrt
Copy link
Contributor

abbeyhrt commented Nov 30, 2021 •
edited
Loading

@sstrubberg this isn't from your changes, it's in https://carbon-react-next.netlify.app/ and this PR's deploy preview but it looks like OverflowMenu is a bit broken right now (I can't access the item with a keyboard either)
Screen Shot 2021-11-30 at 10 53 26 AM

I'm not sure if we would want to address those problems here or in another PR, or fix it before refactoring?

@jnm2377
Copy link
Contributor

jnm2377 commented Nov 30, 2021

Looks good! just had one comment :)

@jnm2377
Copy link
Contributor

jnm2377 commented Nov 30, 2021

@abbeyhrt I can take care of the OverflowMenu component in a different PR.

@abbeyhrt
Copy link
Contributor

It looks like there is some funny business with the mixed class OverflowMenu and the function OverflowMenuItem. Locally running yarn start:v11 , I can't use arrow keys to get to the items, seemingly because handleOverflowMenuItemFocus is undefined. It's supposed to be defined coming from OverFlowMenu cloning the children and adding that prop but I don't think that it works the same now that the children aren't classes.

abbeyhrt
abbeyhrt approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OverflowMenuItem looks good to me! Just some weirdness with props being defined from the parent that should be resolved when OverflowMenu is refactored

@jnm2377 jnm2377 merged commit 74e5703 into carbon-design-system:main Nov 30, 2021
@abbeyhrt abbeyhrt mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

Assignees

@sstrubberg sstrubberg

@jnm2377 jnm2377

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sstrubberg @abbeyhrt @jnm2377