Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump eslint-plugin-jest from 24.3.6 to 25.3.0 #10162

Merged
merged 5 commits into from
Nov 29, 2021
Merged

chore(deps): bump eslint-plugin-jest from 24.3.6 to 25.3.0 #10162

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ff990c
chore(deps): bump eslint-plugin-jest from 24.3.6 to 25.3.0
dependabot[bot] Nov 23, 2021
2949aa1
feat(eslint-config): update eslint-plugin-jest to 25.3
joshblack Nov 29, 2021
1f1d35f
chore(project): run yarn dedupe
joshblack Nov 29, 2021
51ade67
Merge branch 'main' into dependabot/npm_and_yarn/eslint-plugin-jest-2…
joshblack Nov 29, 2021
e29fbfc
Merge branch 'main' into dependabot/npm_and_yarn/eslint-plugin-jest-2…
kodiakhq[bot] Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed .yarn/cache/@types-json-schema-npm-7.0.7-95fb8178d7-ea3b409235.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/@types-json-schema-npm-7.0.9-361918cff3-259d0e25f1.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/@typescript-eslint-experimental-utils-npm-4.28.1-ab919abf02-34a0dd8230.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/@typescript-eslint-experimental-utils-npm-5.4.0-606fccf48f-85c818a147.zip
View file
Open in desktop
Binary file not shown.
Binary file renamed ...ager-npm-4.28.1-0a34d48066-cd310444e9.zip → ...nager-npm-5.4.0-5e3f05fe52-681007e727.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/@typescript-eslint-types-npm-4.28.1-8b00316102-0f4d9530bc.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/@typescript-eslint-types-npm-5.4.0-65ea53d6ea-8d1dc7149e.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/@typescript-eslint-typescript-estree-npm-4.28.1-0862162765-2d95532d38.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/@typescript-eslint-typescript-estree-npm-5.4.0-2418777f04-2f818c629c.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/@typescript-eslint-visitor-keys-npm-4.28.1-989a9be6ea-00564a793e.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/@typescript-eslint-visitor-keys-npm-5.4.0-107ad6b2fc-a0c1c5e3fb.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/eslint-plugin-jest-npm-24.3.6-8f4cddc7a2-233e6055b1.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/eslint-plugin-jest-npm-25.3.0-59c6c408d3-d801c166f5.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/eslint-visitor-keys-npm-3.1.0-9a6ffc9175-fd2d613bb3.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/is-glob-npm-4.0.1-341760116f-84627cad11.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/is-glob-npm-4.0.3-cb87bf1bdb-d381c1319f.zip
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion config/eslint-config-carbon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-cypress": "^2.11.3",
"eslint-plugin-import": "^2.23.4",
"eslint-plugin-jest": "^24.3.6",
"eslint-plugin-jest": "^25.3.0",
"eslint-plugin-jsdoc": "^36.0.3",
"eslint-plugin-jsx-a11y": "^6.4.1",
"eslint-plugin-prettier": "^3.4.0",
Expand Down
11 changes: 4 additions & 7 deletions config/eslint-config-carbon/plugins/jest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ module.exports = {
],

// Enforce lowercase test names
'jest/lowercase-name': 'off',
'jest/prefer-lowercase-title': 'off',

// Disallow alias methods
'jest/no-alias-methods': 'error',
Expand Down Expand Up @@ -108,11 +108,8 @@ module.exports = {
// Suggest using toStrictEqual()
'jest/prefer-strict-equal': 'off',

// Suggest using toBeNull()
'jest/prefer-to-be-null': 'off',

// Suggest using toBeUndefined()
'jest/prefer-to-be-undefined': 'off',
// Suggest using toBe() for primitive literals
'jest/prefer-to-be': 'off',

// Suggest using toContain()
'jest/prefer-to-contain': 'off',
Expand All @@ -130,7 +127,7 @@ module.exports = {
'jest/require-top-level-describe': 'off',

// Enforce valid describe() callback
'jest/valid-describe': 'error',
'jest/valid-describe-callback': 'error',

// Enforce valid expect() usage
'jest/valid-expect': 'error',
Expand Down
25 changes: 0 additions & 25 deletions packages/react/src/components/UIShell/__tests__/HeaderMenu-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,29 +137,4 @@ describe('HeaderMenu', () => {
expect(headerInstance.state.expanded).toEqual(false);
});
});

describe('menu button', () => {
it.skip('should set the given ref on the menu button', () => {});

it.skip('should open and close the menu when interacted with by a mouse', () => {});

it.skip('should focus the first item in the menu if DOWN is pressed', () => {});

it.skip('should focus the last item in the menu if UP is pressed', () => {});
});

describe('menu', () => {
// https://www.w3.org/TR/wai-aria-practices/examples/menubar/menubar-1/menubar-1.html#kbd2_label
it.skip('should close the menu if RIGHT or LEFT are pressed', () => {});

it.skip('should close the menu and set focus on the menu button if ESC is pressed', () => {});

it.skip('should focus the first item if HOME is pressed', () => {});

it.skip('should focus the last item if END is pressed', () => {});

it.skip('should support movement with UP and DOWN keys', () => {});

it.skip('should close the menu if blur occurs that is not in the menu or menubar', () => {});
});
});
107 changes: 58 additions & 49 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6865,10 +6865,10 @@ __metadata:
languageName: node
linkType: hard

"@types/json-schema@npm:^7.0.4, @types/json-schema@npm:^7.0.5, @types/json-schema@npm:^7.0.6, @types/json-schema@npm:^7.0.7":
version: 7.0.7
resolution: "@types/json-schema@npm:7.0.7"
checksum: ea3b409235862d28122751158f4054e729e31ad844bd7b8b23868f38c518047b1c0e8e4e7cc293e02c31a2fb8cfc8a4506c2de2a745cf78b218e064fb8898cd4
"@types/json-schema@npm:^7.0.4, @types/json-schema@npm:^7.0.5, @types/json-schema@npm:^7.0.6, @types/json-schema@npm:^7.0.9":
version: 7.0.9
resolution: "@types/json-schema@npm:7.0.9"
checksum: 259d0e25f11a21ba5c708f7ea47196bd396e379fddb79c76f9f4f62c945879dc21657904914313ec2754e443c5018ea8372362f323f30e0792897fdb2098a705
languageName: node
linkType: hard

Expand Down Expand Up @@ -7269,64 +7269,64 @@ __metadata:
languageName: node
linkType: hard

"@typescript-eslint/experimental-utils@npm:^4.0.1":
version: 4.28.1
resolution: "@typescript-eslint/experimental-utils@npm:4.28.1"
"@typescript-eslint/experimental-utils@npm:^5.0.0":
version: 5.4.0
resolution: "@typescript-eslint/experimental-utils@npm:5.4.0"
dependencies:
"@types/json-schema": ^7.0.7
"@typescript-eslint/scope-manager": 4.28.1
"@typescript-eslint/types": 4.28.1
"@typescript-eslint/typescript-estree": 4.28.1
"@types/json-schema": ^7.0.9
"@typescript-eslint/scope-manager": 5.4.0
"@typescript-eslint/types": 5.4.0
"@typescript-eslint/typescript-estree": 5.4.0
eslint-scope: ^5.1.1
eslint-utils: ^3.0.0
peerDependencies:
eslint: "*"
checksum: 34a0dd8230460b86d7db35426b34ab509c41e6391fd8c5055a75cc90a7fb8f0ecd81bdaf524bcca462dfce83330e8a468d6cef140da4c38628a6af43b5860325
checksum: 85c818a147e86bfde3db8b2ed3f3a79855f9baf539a0f4796715b1632afdd79638bc5bb525ce9e616ee3a0f549889b5e8049a51801ff75eabf13ab4ba474e0f1
languageName: node
linkType: hard

"@typescript-eslint/scope-manager@npm:4.28.1":
version: 4.28.1
resolution: "@typescript-eslint/scope-manager@npm:4.28.1"
"@typescript-eslint/scope-manager@npm:5.4.0":
version: 5.4.0
resolution: "@typescript-eslint/scope-manager@npm:5.4.0"
dependencies:
"@typescript-eslint/types": 4.28.1
"@typescript-eslint/visitor-keys": 4.28.1
checksum: cd310444e9b90aed698e05c7c60c272f25b6e718c3e868be5965f62c7ea98cb9c6aa94b37956a9b4a4d1b4244d7c1bbc9706448b55472c5843c26ad430956c82
"@typescript-eslint/types": 5.4.0
"@typescript-eslint/visitor-keys": 5.4.0
checksum: 681007e727f01b694a8dbec79eba993479eb2c8aa26a0e02832d9e99bca4ba97258d8a2845bd6fb8ab461081a268d5db9b0b67385d357a07d58f78a9386f4682
languageName: node
linkType: hard

"@typescript-eslint/types@npm:4.28.1":
version: 4.28.1
resolution: "@typescript-eslint/types@npm:4.28.1"
checksum: 0f4d9530bc38a8b309ae9fcbeb4e8b197a4b59bcc06ab3ecb17742a53a3f32fdb8dee49c06a7b31f0ff37d5feb5dbb5055684d0dd635f8a1d1cbe8ddb389d41e
"@typescript-eslint/types@npm:5.4.0":
version: 5.4.0
resolution: "@typescript-eslint/types@npm:5.4.0"
checksum: 8d1dc7149e597ae98917cc109136b8c081682158f688b2ca76256493e46b4acfda2135e30258200e83a40492678683393f0eb4d508d43b80b321ea006fc11a38
languageName: node
linkType: hard

"@typescript-eslint/typescript-estree@npm:4.28.1":
version: 4.28.1
resolution: "@typescript-eslint/typescript-estree@npm:4.28.1"
"@typescript-eslint/typescript-estree@npm:5.4.0":
version: 5.4.0
resolution: "@typescript-eslint/typescript-estree@npm:5.4.0"
dependencies:
"@typescript-eslint/types": 4.28.1
"@typescript-eslint/visitor-keys": 4.28.1
debug: ^4.3.1
globby: ^11.0.3
is-glob: ^4.0.1
"@typescript-eslint/types": 5.4.0
"@typescript-eslint/visitor-keys": 5.4.0
debug: ^4.3.2
globby: ^11.0.4
is-glob: ^4.0.3
semver: ^7.3.5
tsutils: ^3.21.0
peerDependenciesMeta:
typescript:
optional: true
checksum: 2d95532d38c57dd320a8fbf0ab18dfe7af3d975f6891340fe552a921f40f556ff3c38b6c0be5c02ee9b1c48e6655027bccef2fd01a3a2b3c9c01a270152c32de
checksum: 2f818c629c2b43b5cb669e9d950b9afadbad94275ef867308f8544277631f723ffd769852a522012c1aef12a9bba11ae46e72469187e3630f7ae373bc8c8a1c0
languageName: node
linkType: hard

"@typescript-eslint/visitor-keys@npm:4.28.1":
version: 4.28.1
resolution: "@typescript-eslint/visitor-keys@npm:4.28.1"
"@typescript-eslint/visitor-keys@npm:5.4.0":
version: 5.4.0
resolution: "@typescript-eslint/visitor-keys@npm:5.4.0"
dependencies:
"@typescript-eslint/types": 4.28.1
eslint-visitor-keys: ^2.0.0
checksum: 00564a793ee249f0d2fc9275559ce09a69d048f6ebdd7a2376fca2c314a1b13a791715ee65eef134e43568ea0b0afe2f9a7658649c9c81a83b25c768d2194c6a
"@typescript-eslint/types": 5.4.0
eslint-visitor-keys: ^3.0.0
checksum: a0c1c5e3fbe2fb6d49e240603f7f613e071a9b5a5a7dd41b7a10cf4d71fbda522c1d3af8389efafd7c03cacd5d2ab9286d6e805d530957aba3a6538b9d248a3a
languageName: node
linkType: hard

Expand Down Expand Up @@ -14980,7 +14980,7 @@ __metadata:
eslint-config-prettier: ^8.3.0
eslint-plugin-cypress: ^2.11.3
eslint-plugin-import: ^2.23.4
eslint-plugin-jest: ^24.3.6
eslint-plugin-jest: ^25.3.0
eslint-plugin-jsdoc: ^36.0.3
eslint-plugin-jsx-a11y: ^6.4.1
eslint-plugin-prettier: ^3.4.0
Expand Down Expand Up @@ -15060,18 +15060,20 @@ __metadata:
languageName: node
linkType: hard

"eslint-plugin-jest@npm:^24.3.6":
version: 24.3.6
resolution: "eslint-plugin-jest@npm:24.3.6"
"eslint-plugin-jest@npm:^25.3.0":
version: 25.3.0
resolution: "eslint-plugin-jest@npm:25.3.0"
dependencies:
"@typescript-eslint/experimental-utils": ^4.0.1
"@typescript-eslint/experimental-utils": ^5.0.0
peerDependencies:
"@typescript-eslint/eslint-plugin": ">= 4"
eslint: ">=5"
"@typescript-eslint/eslint-plugin": ^4.0.0 || ^5.0.0
eslint: ^6.0.0 || ^7.0.0 || ^8.0.0
peerDependenciesMeta:
"@typescript-eslint/eslint-plugin":
optional: true
checksum: 233e6055b167a58ba2e58cf60dc9ce8a4b065d859abe551cf0029d3d6694aaa4a0cfd3b489dfa7442fffb5f40fc7bc0dc322068dd652d08534d1f5c17c7721a8
jest:
optional: true
checksum: d801c166f528392fbb0234e34b893e97c24a7be049744f2d23b1702bce6202d5f0760886a591f884ffa82c7e01a2b06134e86da991bfa568ca5a90311e5f452e
languageName: node
linkType: hard

Expand Down Expand Up @@ -15222,6 +15224,13 @@ __metadata:
languageName: node
linkType: hard

"eslint-visitor-keys@npm:^3.0.0":
version: 3.1.0
resolution: "eslint-visitor-keys@npm:3.1.0"
checksum: fd2d613bb315bc549068ca97771d868437fb60c8f13ef8d6d54669773ff53f814b759fa9e57966f15e4c50a5f5e11c6ba47060b8f201f9776311f6c5d5c11b70
languageName: node
linkType: hard

"eslint@npm:^2.7.0":
version: 2.13.1
resolution: "eslint@npm:2.13.1"
Expand Down Expand Up @@ -19927,12 +19936,12 @@ __metadata:
languageName: node
linkType: hard

"is-glob@npm:^4.0.0, is-glob@npm:^4.0.1, is-glob@npm:~4.0.1":
version: 4.0.1
resolution: "is-glob@npm:4.0.1"
"is-glob@npm:^4.0.0, is-glob@npm:^4.0.1, is-glob@npm:^4.0.3, is-glob@npm:~4.0.1":
version: 4.0.3
resolution: "is-glob@npm:4.0.3"
dependencies:
is-extglob: ^2.1.1
checksum: 84627cad11b4e745f5db5a163f32c47b711585a5ff6e14f8f8d026db87f4cdd3e2c95f6fa1f94ad22e469f36d819ae2814f03f9c668b164422ac3354a94672d3
checksum: d381c1319fcb69d341cc6e6c7cd588e17cd94722d9a32dbd60660b993c4fb7d0f19438674e68dfec686d09b7c73139c9166b47597f846af387450224a8101ab4
languageName: node
linkType: hard

Expand Down