Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-config): add support for loading scss files #10302

Merged

Conversation

joshblack
Copy link
Contributor

Add support for importing sass files from Jest. This is helpful for visibility checks in JSDOM that are based on CSS.

Changelog

New

Changed

  • Update our CSS transformer to compile and insert the require'd CSS into the document head
  • Update our transform options to apply to scss or css

Removed

Testing / Reviewing

  • Verify stylesheet is loaded in the accordion test

@jnm2377
Copy link
Contributor

jnm2377 commented Dec 15, 2021

Hmm. Looks like some theme tests are failing.

@netlify
Copy link

netlify bot commented Dec 16, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: e10e535

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61d4bc20a8687600076b7e3d

😎 Browse the preview: https://deploy-preview-10302--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Dec 16, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: e10e535

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61d4bc20d5f4ec00080ad768

😎 Browse the preview: https://deploy-preview-10302--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Dec 16, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: e10e535

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61d4bc20e9b24500073cc620

😎 Browse the preview: https://deploy-preview-10302--carbon-elements.netlify.app

@joshblack
Copy link
Contributor Author

@jnm2377 just pushed up a fix 👀

@kodiakhq kodiakhq bot merged commit 99e7727 into carbon-design-system:main Jan 4, 2022
@abbeyhrt abbeyhrt mentioned this pull request Jan 14, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants