Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flatpickr): prevent inadvertent text selection in DatePicker #10377

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Jan 11, 2022

Closes #10376

Prevent inadvertent text selection by specifying user-select: none for the flatpickr month buttons.

Changelog

Changed

  • fix(flatpickr): prevent text selection when clicking flatpickr buttons

@metonym metonym requested a review from a team as a code owner January 11, 2022 05:35
@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: beef252

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f05809a361c30007710e11

😎 Browse the preview: https://deploy-preview-10377--carbon-react-next.netlify.app/

@metonym metonym changed the title fix(flatpickr): prevent text selection when clicking flatpickr buttons fix(flatpickr): prevent inadvertent text selection in DatePicker Jan 11, 2022
@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: beef252

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f05809d43b8b00070b25a2

😎 Browse the preview: https://deploy-preview-10377--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: bbfc6c5

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61dd17135c41800008ce77fa

😎 Browse the preview: https://deploy-preview-10377--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: beef252

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f05809ef4e960007b18f8f

😎 Browse the preview: https://deploy-preview-10377--carbon-components-react.netlify.app/

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this fix!

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 ✅

@kodiakhq kodiakhq bot merged commit a7112be into carbon-design-system:main Jan 25, 2022
@abbeyhrt abbeyhrt mentioned this pull request Jan 27, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Double clicking prev/next month in DatePicker can cause text to be selected
4 participants