-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabs): make debounce wait configurable prop #10385
feat(tabs): make debounce wait configurable prop #10385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: c39c04a 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61eb37b24e1a20000723837b 😎 Browse the preview: https://deploy-preview-10385--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: c39c04a 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61eb37b28271f2000720b792 😎 Browse the preview: https://deploy-preview-10385--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: c39c04a 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61eb37b289a7d400078c38e6 😎 Browse the preview: https://deploy-preview-10385--carbon-components-react.netlify.app |
Refs #9698, #10120
In some situations the the call stack exceeded bug identified in #9698 still happens. This PR adds a new prop so the scroll handler's debounce wait ms is configurable for consumers who identify the need for a more aggressive debounce.
Changelog
New
Changed
Testing / Reviewing
tabs
stories in thecarbon-components-react
storybook.Error: Maximum update depth exceeded.