Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): make debounce wait configurable prop #10385

Merged

Conversation

tay1orjones
Copy link
Member

Refs #9698, #10120

In some situations the the call stack exceeded bug identified in #9698 still happens. This PR adds a new prop so the scroll handler's debounce wait ms is configurable for consumers who identify the need for a more aggressive debounce.

Changelog

New

  • tabs: provide prop to configure scroll handler debounce wait ms

Changed

  • tabs: increase default debounce wait by 25ms to 150ms

Testing / Reviewing

  • The original issue was only present in Safari. Particularly with a trackpad as an input device.
  • In Safari, Check the tabs stories in the carbon-components-react storybook.
  • Scroll back and forth multiple times (10-20 times) and ensure that React does not throw an error; Error: Maximum update depth exceeded.

@tay1orjones tay1orjones requested a review from a team as a code owner January 11, 2022 21:08
Copy link
Member

@dabrad26 dabrad26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: c39c04a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61eb37b24e1a20000723837b

😎 Browse the preview: https://deploy-preview-10385--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: c39c04a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61eb37b28271f2000720b792

😎 Browse the preview: https://deploy-preview-10385--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: c39c04a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61eb37b289a7d400078c38e6

😎 Browse the preview: https://deploy-preview-10385--carbon-components-react.netlify.app

@tay1orjones tay1orjones requested a review from a team as a code owner January 12, 2022 19:01
@tay1orjones tay1orjones requested review from dakahn and removed request for tw15egan January 19, 2022 21:51
@kodiakhq kodiakhq bot merged commit 8272a2e into carbon-design-system:main Jan 21, 2022
@abbeyhrt abbeyhrt mentioned this pull request Jan 27, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants