Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storybook): use STORYBOOK_* env variables #10546

Merged

Conversation

joshblack
Copy link
Contributor

It seems like in newer versions of storybook, only STORYBOOK_ prefixed environment variables are passed along. This PR updates our ENV variables to follow this standard and re-enable our theme preview in the classic storybook

Changelog

New

Changed

  • Update classic storybook to use STORYBOOK_* prefixed ENV variables

Removed

Testing / Reviewing

  • Verify theme panel shows up in our classic storybook and is able to change the theme

@joshblack joshblack requested a review from a team as a code owner January 27, 2022 20:17
@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 113a3b1

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f330a4441fab00087b1b27

😎 Browse the preview: https://deploy-preview-10546--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 113a3b1

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f330a40fd890000820f190

😎 Browse the preview: https://deploy-preview-10546--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 113a3b1

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f330a43703aa0008767f30

😎 Browse the preview: https://deploy-preview-10546--carbon-elements.netlify.app

@kodiakhq kodiakhq bot merged commit c3771b2 into carbon-design-system:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants