Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pagination): fix tokens based on audit #10817

Merged
merged 7 commits into from
Feb 28, 2022
Merged

fix(pagination): fix tokens based on audit #10817

merged 7 commits into from
Feb 28, 2022

Conversation

tw15egan
Copy link
Collaborator

Refs #10425

Screen Shot 2022-02-22 at 11 42 02 AM

Updates Pagination based on feedback

Changelog

Changed

  • Changed tokens based on feedback

Testing / Reviewing

Verify component renders as expected

@tw15egan tw15egan requested a review from a team as a code owner February 22, 2022 16:53
@netlify
Copy link

netlify bot commented Feb 22, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 0c5d34f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/621d35eee0af00000728647e

😎 Browse the preview: https://deploy-preview-10817--carbon-react-next.netlify.app

@tw15egan tw15egan mentioned this pull request Feb 22, 2022
Merged
@netlify
Copy link

netlify bot commented Feb 22, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0c5d34f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/621d35ee04875800073b0700

😎 Browse the preview: https://deploy-preview-10817--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Feb 22, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 0c5d34f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/621d35ee019470000853a64f

😎 Browse the preview: https://deploy-preview-10817--carbon-elements.netlify.app

abbeyhrt
abbeyhrt approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

laurenmrice
laurenmrice requested changes Feb 23, 2022
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment •
edited by tw15egan
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The "1 – 10 of 103 items" text should be color token $text-secondary. Everything else looks great!
    Artboard

@tw15egan
Copy link
Collaborator Author

@laurenmrice updated 👍🏻

laurenmrice
laurenmrice approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@kodiakhq kodiakhq bot merged commit 53413ac into carbon-design-system:main Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@dakahn dakahn dakahn approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tw15egan @abbeyhrt @dakahn @laurenmrice @tay1orjones