-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): fixed styling of med size search component #11190
fix(react): fixed styling of med size search component #11190
Conversation
The Search component has some extra css styling just for md size. Which seems to make a breaking positioning for the icon. This fix removes this without affecting any other styling
DCO Assistant Lite bot All contributors have signed the DCO. |
I have read the DCO document and I hereby sign the DCO. |
recheck |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Is anything holding this PR up? |
@alexandertrefz Nothing holding it up, I think we just forgot to turn on auto-merge. Sorry for the delay, this should be merged shortly! |
@tay1orjones or @joshblack is this change released in prod yet ? if so, does it affect carbon 11? |
@TannerS Yeah, looks like the commit merged in was tagged with |
The Search component has some extra css styling just for md size.
Which seems to make a breaking positioning for the icon.
This fix removes this without affecting any other styling
Closes #11169
Closes
Found this issue but not yet reported if this issue is valid or not. But I opened up a PR to be ready with a possible fix if so.
Changelog
Removed
md
size for theSearch
component. I am no sure why this styling was added as it seems to not affect anythign when removed but fix the issue at hand.Tagging @joshblack since he was on the blame for this and may have some insights!
Testing / Reviewing
Ran unit test and verified
Search
component on storybook