Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fixed styling of med size search component #11190

Conversation

TannerS
Copy link
Contributor

@TannerS TannerS commented Apr 10, 2022

The Search component has some extra css styling just for md size.
Which seems to make a breaking positioning for the icon.
This fix removes this without affecting any other styling

Closes #11169

Closes

Found this issue but not yet reported if this issue is valid or not. But I opened up a PR to be ready with a possible fix if so.

Changelog

Removed

  • Removed extra set of stylings for the md size for the Search component. I am no sure why this styling was added as it seems to not affect anythign when removed but fix the issue at hand.

Tagging @joshblack since he was on the blame for this and may have some insights!

Testing / Reviewing

Ran unit test and verified Search component on storybook

The Search component has some extra css styling just for md size.
Which seems to make a breaking positioning for the icon.
This fix removes this without affecting any other styling
@TannerS TannerS requested a review from a team as a code owner April 10, 2022 07:51
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2022

DCO Assistant Lite bot All contributors have signed the DCO.

@TannerS
Copy link
Contributor Author

TannerS commented Apr 10, 2022

I have read the DCO document and I hereby sign the DCO.

@TannerS
Copy link
Contributor Author

TannerS commented Apr 10, 2022

recheck

@netlify
Copy link

netlify bot commented Apr 10, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2bda1ff
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6261711f657cb90009e90855
😎 Deploy Preview https://deploy-preview-11190--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 10, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2bda1ff
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6261711e66934c0008e64da0
😎 Deploy Preview https://deploy-preview-11190--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@alexandertrefz
Copy link

Is anything holding this PR up?

@tay1orjones
Copy link
Member

@alexandertrefz Nothing holding it up, I think we just forgot to turn on auto-merge. Sorry for the delay, this should be merged shortly!

@kodiakhq kodiakhq bot merged commit da1fa5e into carbon-design-system:main Apr 21, 2022
@TannerS
Copy link
Contributor Author

TannerS commented May 4, 2022

@tay1orjones or @joshblack is this change released in prod yet ?

if so, does it affect carbon 11?

@tay1orjones
Copy link
Member

@TannerS Yeah, looks like the commit merged in was tagged with v11.2.0, so should be released. Equivalent @carbon/react version would be v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Search size prop with md value icon is misaligned in carbon 11
5 participants