Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fix ally issue in datatable in storybook #11217

Merged

Conversation

TannerS
Copy link
Contributor

@TannerS TannerS commented Apr 13, 2022

Closes #

No current issue

Changelog

Changed

Added fields in storybook for expandable table similar to this PR => #10547

Testing / Reviewing

Reviewed in local storybook and ran the IBM a11y tool

@TannerS TannerS requested a review from a team as a code owner April 13, 2022 01:46
@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cdfd36a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6266c28f0a51f00008dcb617
😎 Deploy Preview https://deploy-preview-11217--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit cdfd36a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6266c28fdc2234000837cc4b
😎 Deploy Preview https://deploy-preview-11217--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tay1orjones
Copy link
Member

@TannerS Was this just that the BatchExpansion and Usage stories show an error in accessibility checker in prod, and the deploy preview here should show no errors for these stories?

@TannerS
Copy link
Contributor Author

TannerS commented Apr 19, 2022 via email

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No info and relationships violations that I can see on those two stories 👍

image

@kodiakhq kodiakhq bot merged commit 52e4888 into carbon-design-system:main Apr 25, 2022
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
…11217)

### Description

This merges the `release/v2.0.0` release branch into `main`.

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
…-system#11217)"

This reverts commit c05362f.

Signed-off-by: Kenny Lam <909118+kennylam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants