Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(react): update Tile, ContentSwitcher to exclude light prop #11263

Merged
merged 2 commits into from
Apr 25, 2022
Merged

docs(react): update Tile, ContentSwitcher to exclude light prop #11263

merged 2 commits into from
Apr 25, 2022

Conversation

joshblack
Copy link
Contributor

Closes #11249

Changelog

New

Changed

  • The Tile and ContentSwitcher stories now hide light from the controls table

Removed

Testing / Reviewing

  • View the Tile and ContentSwitcher stories and verify that the light prop is no longer visible

@joshblack joshblack requested a review from a team as a code owner April 21, 2022 16:20
@netlify
Copy link

netlify bot commented Apr 21, 2022 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f24bfba
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6266c6acd813690009ab4683
😎 Deploy Preview https://deploy-preview-11263--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 21, 2022 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f24bfba
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6266c6ac90e950000893fc31
😎 Deploy Preview https://deploy-preview-11263--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

aledavila
aledavila approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this. looks good

@kodiakhq kodiakhq bot merged commit 46ee71b into carbon-design-system:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledavila aledavila aledavila approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@abbeyhrt abbeyhrt Awaiting requested review from abbeyhrt abbeyhrt was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated props from being visible in controls of storybook
3 participants
@joshblack @tay1orjones @aledavila