Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(progress-bar): port support for statuses from v10 to v11 #11329

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented May 2, 2022

This mirrors the changes from #10843 from the v10 branch into main. I attempted to actually cherry pick the commit, but the histories are so diverged the merge was a nightmare. I manually ported the changes over.

@janhassel it would be awesome if you could give this a glance to ensure I'm on the mark here.

Changelog

New

  • add support for statuses in progress bar
  • add progress bar playground story

Testing / Reviewing

From the original PR:

  • Run storybook
  • Compare different statuses with the design guidance in Progress bar docs carbon-website#2688
  • Status "finished" should set its value to max
  • Status "error" should set its value to 0 and emit aria-invalid
  • In the inline variant, the bar should be visually hidden (though accessible) with only the icon and label being shown
    • This is because the inline variant is supposed to be used when space is tight, e.g. in a data table cell and @thyhmdo and I agreed that priorizing the label and icon over the 100%-full bar would be the best option

@tay1orjones tay1orjones requested review from a team as code owners May 2, 2022 18:44
@tay1orjones tay1orjones self-assigned this May 2, 2022
@tay1orjones tay1orjones changed the title feat(progress-bar): add support for statuses in v11 feat(progress-bar): port support for statuses from v10 to v11 May 2, 2022
@netlify
Copy link

netlify bot commented May 2, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2a6487e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/627435e552766e00085162e6
😎 Deploy Preview https://deploy-preview-11329--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 2, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2a6487e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/627435e53c00ae0009db0740
😎 Deploy Preview https://deploy-preview-11329--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@janhassel janhassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit c7521ed into carbon-design-system:main May 5, 2022
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
* feat(lit): bump up to lit 3

* chore(prettier): format code

---------

Co-authored-by: Kenny Lam <909118+kennylam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants