fix(styles): remove black fill for inline actionable notification icon #11487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dakahn
approved these changes
May 26, 2022
aledavila
approved these changes
May 31, 2022
kennylam
pushed a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
…on-design-system#11487) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@carbon/icon-helpers](https://togithub.com/carbon-design-system/carbon) ([source](https://togithub.com/carbon-design-system/carbon/tree/HEAD/packages/icon-helpers)) | [`10.45.1` -> `10.46.0`](https://renovatebot.com/diffs/npm/@carbon%2ficon-helpers/10.45.1/10.46.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>carbon-design-system/carbon (@&carbon-design-system#8203;carbon/icon-helpers)</summary> ### [`v10.46.0`](https://togithub.com/carbon-design-system/carbon/releases/tag/v10.46.0) [Compare Source](https://togithub.com/carbon-design-system/carbon/compare/d6904c019acc9b8cb8f5a01732bc963a71fa93bf...v10.46.0) ##### `@carbon/react@0.7.0` ##### New features 🚀 - feat(tag): add outline variant ([#&carbon-design-system#8203;9792](https://togithub.com/carbon-design-system/carbon/issues/9792)) ([`d02a8e55c`](https://togithub.com/carbon-design-system/carbon/commit/d02a8e55c)) ##### Bug fixes 🐛 - fix(grid): make subgrid work with grid offset ([#&carbon-design-system#8203;9803](https://togithub.com/carbon-design-system/carbon/issues/9803)) ([`9f558cf7e`](https://togithub.com/carbon-design-system/carbon/commit/9f558cf7e)) ##### Housekeeping 🏠 - chore(release): v10.46.0 ([#&carbon-design-system#8203;9868](https://togithub.com/carbon-design-system/carbon/issues/9868)) ([`3c9fdbcc1`](https://togithub.com/carbon-design-system/carbon/commit/3c9fdbcc1)) - chore(release): v10.46.0-rc.0 ([#&carbon-design-system#8203;9849](https://togithub.com/carbon-design-system/carbon/issues/9849)) ([`1730d730f`](https://togithub.com/carbon-design-system/carbon/commit/1730d730f)) ##### `carbon-components@10.46.0` ##### New features 🚀 - feat(tag): add outline variant ([#&carbon-design-system#8203;9792](https://togithub.com/carbon-design-system/carbon/issues/9792)) ([`d02a8e55c`](https://togithub.com/carbon-design-system/carbon/commit/d02a8e55c)) ##### Bug fixes 🐛 - fix(slider): correct input width ([#&carbon-design-system#8203;9829](https://togithub.com/carbon-design-system/carbon/issues/9829)) ([`1a6eaf254`](https://togithub.com/carbon-design-system/carbon/commit/1a6eaf254)) - fix: add shadow token, update overlay token ([#&carbon-design-system#8203;9812](https://togithub.com/carbon-design-system/carbon/issues/9812)) ([`113bcf54c`](https://togithub.com/carbon-design-system/carbon/commit/113bcf54c)) - fix(accordion): update arrow spacing for start variant ([#&carbon-design-system#8203;9777](https://togithub.com/carbon-design-system/carbon/issues/9777)) ([`ec433dc5a`](https://togithub.com/carbon-design-system/carbon/commit/ec433dc5a)) - fix(Modal): updates content spacing ([#&carbon-design-system#8203;9700](https://togithub.com/carbon-design-system/carbon/issues/9700)) ([`2da12d0d9`](https://togithub.com/carbon-design-system/carbon/commit/2da12d0d9)) - fix(Select): fix background issues with inline variant optgroups ([#&carbon-design-system#8203;9636](https://togithub.com/carbon-design-system/carbon/issues/9636)) ([`be4e7704a`](https://togithub.com/carbon-design-system/carbon/commit/be4e7704a)) ##### Housekeeping 🏠 - chore(release): v10.46.0 ([#&carbon-design-system#8203;9868](https://togithub.com/carbon-design-system/carbon/issues/9868)) ([`3c9fdbcc1`](https://togithub.com/carbon-design-system/carbon/commit/3c9fdbcc1)) - chore(release): v10.46.0-rc.0 ([#&carbon-design-system#8203;9849](https://togithub.com/carbon-design-system/carbon/issues/9849)) ([`1730d730f`](https://togithub.com/carbon-design-system/carbon/commit/1730d730f)) ##### `@carbon/elements@10.45.0` ##### Bug fixes 🐛 - fix: add shadow token, update overlay token ([#&carbon-design-system#8203;9812](https://togithub.com/carbon-design-system/carbon/issues/9812)) ([`113bcf54c`](https://togithub.com/carbon-design-system/carbon/commit/113bcf54c)) ##### Housekeeping 🏠 - chore(release): v10.46.0 ([#&carbon-design-system#8203;9868](https://togithub.com/carbon-design-system/carbon/issues/9868)) ([`3c9fdbcc1`](https://togithub.com/carbon-design-system/carbon/commit/3c9fdbcc1)) - chore(release): v10.46.0-rc.0 ([#&carbon-design-system#8203;9849](https://togithub.com/carbon-design-system/carbon/issues/9849)) ([`1730d730f`](https://togithub.com/carbon-design-system/carbon/commit/1730d730f)) ##### `@carbon/grid@10.38.0` ##### Bug fixes 🐛 - fix(grid): make subgrid work with grid offset ([#&carbon-design-system#8203;9803](https://togithub.com/carbon-design-system/carbon/issues/9803)) ([`9f558cf7e`](https://togithub.com/carbon-design-system/carbon/commit/9f558cf7e)) ##### Housekeeping 🏠 - chore(release): v10.46.0 ([#&carbon-design-system#8203;9868](https://togithub.com/carbon-design-system/carbon/issues/9868)) ([`3c9fdbcc1`](https://togithub.com/carbon-design-system/carbon/commit/3c9fdbcc1)) ##### `@carbon/icons-handlebars@10.41.0` ##### Housekeeping 🏠 - chore(release): v10.46.0 ([#&carbon-design-system#8203;9868](https://togithub.com/carbon-design-system/carbon/issues/9868)) ([`3c9fdbcc1`](https://togithub.com/carbon-design-system/carbon/commit/3c9fdbcc1)) - chore(release): v10.46.0-rc.0 ([#&carbon-design-system#8203;9849](https://togithub.com/carbon-design-system/carbon/issues/9849)) ([`1730d730f`](https://togithub.com/carbon-design-system/carbon/commit/1730d730f)) ##### `@carbon/icons-react@10.41.0` ##### Housekeeping 🏠 - chore(release): v10.46.0 ([#&carbon-design-system#8203;9868](https://togithub.com/carbon-design-system/carbon/issues/9868)) ([`3c9fdbcc1`](https://togithub.com/carbon-design-system/carbon/commit/3c9fdbcc1)) - chore(release): v10.46.0-rc.0 ([#&carbon-design-system#8203;9849](https://togithub.com/carbon-design-system/carbon/issues/9849)) ([`1730d730f`](https://togithub.com/carbon-design-system/carbon/commit/1730d730f)) ##### `@carbon/icons-vue@10.41.0` ##### Housekeeping 🏠 - chore(release): v10.46.0 ([#&carbon-design-system#8203;9868](https://togithub.com/carbon-design-system/carbon/issues/9868)) ([`3c9fdbcc1`](https://togithub.com/carbon-design-system/carbon/commit/3c9fdbcc1)) - chore(release): v10.46.0-rc.0 ([#&carbon-design-system#8203;9849](https://togithub.com/carbon-design-system/carbon/issues/9849)) ([`1730d730f`](https://togithub.com/carbon-design-system/carbon/commit/1730d730f)) ##### `@carbon/icons@10.41.0` ##### New features 🚀 - feat(icons): Update icons.yml 0916 ([#&carbon-design-system#8203;9595](https://togithub.com/carbon-design-system/carbon/issues/9595)) ([`61b5aaa8e`](https://togithub.com/carbon-design-system/carbon/commit/61b5aaa8e)) ##### Housekeeping 🏠 - chore(release): v10.46.0 ([#&carbon-design-system#8203;9868](https://togithub.com/carbon-design-system/carbon/issues/9868)) ([`3c9fdbcc1`](https://togithub.com/carbon-design-system/carbon/commit/3c9fdbcc1)) - chore(release): v10.46.0-rc.0 ([#&carbon-design-system#8203;9849](https://togithub.com/carbon-design-system/carbon/issues/9849)) ([`1730d730f`](https://togithub.com/carbon-design-system/carbon/commit/1730d730f)) ##### `carbon-components-react@7.46.0` ##### New features 🚀 - feat(MultiSelect): new hideLabel prop ([#&carbon-design-system#8203;9840](https://togithub.com/carbon-design-system/carbon/issues/9840)) ([`2fe7fbe6d`](https://togithub.com/carbon-design-system/carbon/commit/2fe7fbe6d)) - feat(checkbox): add onClick prop ([#&carbon-design-system#8203;9827](https://togithub.com/carbon-design-system/carbon/issues/9827)) ([`dd1d03734`](https://togithub.com/carbon-design-system/carbon/commit/dd1d03734)) - feat(tooltip): Add optional prop to auto orientate within parent bounds ([#&carbon-design-system#8203;9556](https://togithub.com/carbon-design-system/carbon/issues/9556)) ([`a82d3f4c9`](https://togithub.com/carbon-design-system/carbon/commit/a82d3f4c9)) - feat(search): add onClear callback prop to Search/DataTableSearch ([#&carbon-design-system#8203;9737](https://togithub.com/carbon-design-system/carbon/issues/9737)) ([`3e0231dd7`](https://togithub.com/carbon-design-system/carbon/commit/3e0231dd7)) - feat(props): update table expand header props ([#&carbon-design-system#8203;9659](https://togithub.com/carbon-design-system/carbon/issues/9659)) ([`75646c07a`](https://togithub.com/carbon-design-system/carbon/commit/75646c07a)) - feat(tag): add outline variant ([#&carbon-design-system#8203;9792](https://togithub.com/carbon-design-system/carbon/issues/9792)) ([`d02a8e55c`](https://togithub.com/carbon-design-system/carbon/commit/d02a8e55c)) ##### Bug fixes 🐛 - fix(grid): make subgrid work with grid offset ([#&carbon-design-system#8203;9803](https://togithub.com/carbon-design-system/carbon/issues/9803)) ([`9f558cf7e`](https://togithub.com/carbon-design-system/carbon/commit/9f558cf7e)) - fix(OverflowMenu): add stopPropagation call to handleClick method ([#&carbon-design-system#8203;9816](https://togithub.com/carbon-design-system/carbon/issues/9816)) ([`c53e70818`](https://togithub.com/carbon-design-system/carbon/commit/c53e70818)) - fix(Modal): fix Formik bug in Modal ([#&carbon-design-system#8203;9797](https://togithub.com/carbon-design-system/carbon/issues/9797)) ([`2612bbdad`](https://togithub.com/carbon-design-system/carbon/commit/2612bbdad)) - fix(MultiSelect): fix phantom selection on MenuKeyDownEnter 👻 ([#&carbon-design-system#8203;9765](https://togithub.com/carbon-design-system/carbon/issues/9765)) ([`6e523982a`](https://togithub.com/carbon-design-system/carbon/commit/6e523982a)) - fix(tooltip): Fix tooltip alignment aligned on right hand side of container ([#&carbon-design-system#8203;9606](https://togithub.com/carbon-design-system/carbon/issues/9606)) ([`3af8a9422`](https://togithub.com/carbon-design-system/carbon/commit/3af8a9422)) - fix(Modal): updates content spacing ([#&carbon-design-system#8203;9700](https://togithub.com/carbon-design-system/carbon/issues/9700)) ([`2da12d0d9`](https://togithub.com/carbon-design-system/carbon/commit/2da12d0d9)) ##### Housekeeping 🏠 - chore(release): v10.46.0 ([#&carbon-design-system#8203;9868](https://togithub.com/carbon-design-system/carbon/issues/9868)) ([`3c9fdbcc1`](https://togithub.com/carbon-design-system/carbon/commit/3c9fdbcc1)) - chore(tile): refactor to functional component ([#&carbon-design-system#8203;9721](https://togithub.com/carbon-design-system/carbon/issues/9721)) ([`83f265892`](https://togithub.com/carbon-design-system/carbon/commit/83f265892)) - chore(release): v10.46.0-rc.0 ([#&carbon-design-system#8203;9849](https://togithub.com/carbon-design-system/carbon/issues/9849)) ([`1730d730f`](https://togithub.com/carbon-design-system/carbon/commit/1730d730f)) - chore(deps): bump url-parse ([#&carbon-design-system#8203;9806](https://togithub.com/carbon-design-system/carbon/issues/9806)) ([`0152e7416`](https://togithub.com/carbon-design-system/carbon/commit/0152e7416)) ##### `@carbon/styles@0.7.0` ##### New features 🚀 - feat(tag): add outline variant ([#&carbon-design-system#8203;9792](https://togithub.com/carbon-design-system/carbon/issues/9792)) ([`d02a8e55c`](https://togithub.com/carbon-design-system/carbon/commit/d02a8e55c)) ##### Bug fixes 🐛 - fix(slider): correct input width ([#&carbon-design-system#8203;9829](https://togithub.com/carbon-design-system/carbon/issues/9829)) ([`1a6eaf254`](https://togithub.com/carbon-design-system/carbon/commit/1a6eaf254)) - fix: add shadow token, update overlay token ([#&carbon-design-system#8203;9812](https://togithub.com/carbon-design-system/carbon/issues/9812)) ([`113bcf54c`](https://togithub.com/carbon-design-system/carbon/commit/113bcf54c)) - fix(notification): actionable non-inline layout close button layout bug ([#&carbon-design-system#8203;9773](https://togithub.com/carbon-design-system/carbon/issues/9773)) ([`cd6fc390f`](https://togithub.com/carbon-design-system/carbon/commit/cd6fc390f)) - fix(accordion): update arrow spacing for start variant ([#&carbon-design-system#8203;9777](https://togithub.com/carbon-design-system/carbon/issues/9777)) ([`ec433dc5a`](https://togithub.com/carbon-design-system/carbon/commit/ec433dc5a)) ##### Housekeeping 🏠 - chore(release): v10.46.0 ([#&carbon-design-system#8203;9868](https://togithub.com/carbon-design-system/carbon/issues/9868)) ([`3c9fdbcc1`](https://togithub.com/carbon-design-system/carbon/commit/3c9fdbcc1)) - chore(release): v10.46.0-rc.0 ([#&carbon-design-system#8203;9849](https://togithub.com/carbon-design-system/carbon/issues/9849)) ([`1730d730f`](https://togithub.com/carbon-design-system/carbon/commit/1730d730f)) ##### `@carbon/themes@10.45.0` ##### Bug fixes 🐛 - fix: add shadow token, update overlay token ([#&carbon-design-system#8203;9812](https://togithub.com/carbon-design-system/carbon/issues/9812)) ([`113bcf54c`](https://togithub.com/carbon-design-system/carbon/commit/113bcf54c)) ##### Housekeeping 🏠 - chore(release): v10.46.0 ([#&carbon-design-system#8203;9868](https://togithub.com/carbon-design-system/carbon/issues/9868)) ([`3c9fdbcc1`](https://togithub.com/carbon-design-system/carbon/commit/3c9fdbcc1)) - chore(release): v10.46.0-rc.0 ([#&carbon-design-system#8203;9849](https://togithub.com/carbon-design-system/carbon/issues/9849)) ([`1730d730f`](https://togithub.com/carbon-design-system/carbon/commit/1730d730f)) ##### `@carbon/type@10.37.0` ##### Housekeeping 🏠 - chore(deps): bump url-parse in /packages/type/examples/styled-components ([#&carbon-design-system#8203;9810](https://togithub.com/carbon-design-system/carbon/issues/9810)) ([`269867cdf`](https://togithub.com/carbon-design-system/carbon/commit/269867cdf)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/carbon-design-system/carbon-for-ibm-dotcom). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11483
Removes styles that filled inline warning icon with black fill unnecessarily.
Testing / Reviewing
Go to Actionable notification story, make it
inlineand kind="warning" and make sure that the icon is the correct color.