Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): add titleText to multiselect in modal story #11488

Merged
merged 3 commits into from
May 26, 2022

Conversation

abbeyhrt
Copy link
Contributor

REF #11444

Updates modal story to pass AC checker

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

Go to modal story and run AC checker to ensure there are no violations(besides the "content does not reside in landmark" one)

@netlify
Copy link

netlify bot commented May 25, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 728d5b1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/628ff3938a965000084fe48b
😎 Deploy Preview https://deploy-preview-11488--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 25, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 728d5b1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/628ff39341ac1800093bf6ce
😎 Deploy Preview https://deploy-preview-11488--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit 39bee79 into carbon-design-system:main May 26, 2022
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
…bon-design-system#11488)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [mini-css-extract-plugin](https://togithub.com/webpack-contrib/mini-css-extract-plugin) | [`~2.7.0` -> `~2.8.0`](https://renovatebot.com/diffs/npm/mini-css-extract-plugin/2.7.7/2.8.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/mini-css-extract-plugin/2.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/mini-css-extract-plugin/2.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/mini-css-extract-plugin/2.7.7/2.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/mini-css-extract-plugin/2.7.7/2.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>webpack-contrib/mini-css-extract-plugin (mini-css-extract-plugin)</summary>

### [`v2.8.0`](https://togithub.com/webpack-contrib/mini-css-extract-plugin/blob/HEAD/CHANGELOG.md#280-2024-02-01)

[Compare Source](https://togithub.com/webpack-contrib/mini-css-extract-plugin/compare/v2.7.7...v2.8.0)

##### Features

-   added the `beforeTagInsert` hook ([#&carbon-design-system#8203;1054](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/1054)) ([6313bf6](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/6313bf629c1c76ec7b07dc60fef06e39702a63d9))
-   support named exports with any characters ([b656c5c](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/b656c5c98dcffcae51f5208e961ce089be6607a8))

##### [2.7.7](https://togithub.com/webpack-contrib/mini-css-extract-plugin/compare/v2.7.6...v2.7.7) (2024-01-10)

##### Bug Fixes

-   add ';' to import media queries ([#&carbon-design-system#8203;1051](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/1051)) ([98acf2b](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/98acf2bbd08ba0988318c6d364b9aa14f84ed79a))
-   add `ChunkLoadError` name to chunk loading error ([#&carbon-design-system#8203;1073](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/1073)) ([e3f8375](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/e3f837574bdad9dc583028c6f9a9a2f3082d9ecb))
-   adding media, supports and layer for external import ([#&carbon-design-system#8203;1072](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/1072)) ([60c5331](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/60c53311c125425d2e742414ed6dbd59cea8cbe4))
-   css experiment detection ([#&carbon-design-system#8203;1067](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/1067)) ([82f4a47](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/82f4a47f3ddc7cdbba311bee50d85dd4b3e6bfb1))

##### [2.7.6](https://togithub.com/webpack-contrib/mini-css-extract-plugin/compare/v2.7.5...v2.7.6) (2023-05-19)

##### Bug Fixes

-   compatibility with built-in CSS support ([#&carbon-design-system#8203;1035](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/1035)) ([f576ed6](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/f576ed6a530db555d7442ebab1f9a09f3acff13f))

##### [2.7.5](https://togithub.com/webpack-contrib/mini-css-extract-plugin/compare/v2.7.4...v2.7.5) (2023-03-16)

##### Bug Fixes

-   don't invalidate cache after timeout refresh ([#&carbon-design-system#8203;1023](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/1023)) ([38d8513](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/38d8513f97983698b3b4417abb8bacaee0ea68fb))
-   readable identifier ([#&carbon-design-system#8203;1024](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/1024)) ([721bbf1](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/721bbf104030c96acff14ad2b7a23edc4f1e277d))

##### [2.7.4](https://togithub.com/webpack-contrib/mini-css-extract-plugin/compare/v2.7.3...v2.7.4) (2023-03-16)

##### Bug Fixes

-   module identifier, don't merge modules with different media/suppors/layer ([#&carbon-design-system#8203;1021](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/1021)) ([ad3729b](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/ad3729ba9d3fed328a170340eafb66e8c2a13bdc))

##### [2.7.3](https://togithub.com/webpack-contrib/mini-css-extract-plugin/compare/v2.7.2...v2.7.3) (2023-03-07)

##### Bug Fixes

-   avoid to throw error when link doesn't have parentNode ([#&carbon-design-system#8203;1016](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/1016)) ([6292440](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/62924409895ff6e0e4e599f6734c109ec40e6eff))

##### [2.7.2](https://togithub.com/webpack-contrib/mini-css-extract-plugin/compare/v2.7.1...v2.7.2) (2022-12-06)

##### Bug Fixes

-   don't crash in web workers ([#&carbon-design-system#8203;1004](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/1004)) ([4d98d4b](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/4d98d4b973be27910b84194e6f7acb1d09f1e8ae))

##### [2.7.1](https://togithub.com/webpack-contrib/mini-css-extract-plugin/compare/v2.7.0...v2.7.1) (2022-11-29)

##### Bug Fixes

-   preserve order of link tags on HMR ([#&carbon-design-system#8203;982](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/982)) ([6ea0922](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/6ea092258944fd0330b84dd3455bff9a15320837))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/carbon-design-system/carbon-for-ibm-dotcom).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants