Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(react): update Form components' tests to RTL #11691

Merged
merged 6 commits into from
Jul 5, 2022

Conversation

abbeyhrt
Copy link
Contributor

Closes #11644
Closes #11643
Closes #11642
Closes #11641

Updates tests to RTL for Form, FormGroup, FormLabel, and FormItem. Those components don't have much behavior to them (if any as far as I could tell) so the tests verify that the props are working as expected.

@abbeyhrt abbeyhrt requested a review from a team as a code owner June 27, 2022 20:30
@netlify
Copy link

netlify bot commented Jun 27, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit dd3ea12
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62ba13715ab5080007d36276
😎 Deploy Preview https://deploy-preview-11691--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 27, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit dd3ea12
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62ba1371e1e24f0009ed461e
😎 Deploy Preview https://deploy-preview-11691--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 27, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ebca1b4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62c48582182f0e0008375fe3
😎 Deploy Preview https://deploy-preview-11691--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 27, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ebca1b4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62c4858228d0ad0009643584
😎 Deploy Preview https://deploy-preview-11691--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

abbeyhrt and others added 2 commits June 28, 2022 11:03
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit c095635 into carbon-design-system:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants