Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DatePicker): add Readonly date picker #12426

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

lee-chase
Copy link
Member

@lee-chase lee-chase commented Oct 28, 2022

Contributes to #2177

Closes #12401

Adds the read-only feature to the DatePicker component.

Changelog

Added

  • Adds readOnly property to DatePicker and functionality
  • Adds test for read-only DatePicker
  • Adds styling for read-only DatePicker.

Testing / Reviewing

Reviewed the result in Storybook and a added read-only test.

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c077d91
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6372b7061526c700099992ac
😎 Deploy Preview https://deploy-preview-12426--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c077d91
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6372b706718a8e0009a62b51
😎 Deploy Preview https://deploy-preview-12426--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@alisonjoseph alisonjoseph requested review from a team and aagonzales and removed request for a team November 11, 2022 13:57
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually looks good, matches spec 👍

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@tw15egan tw15egan changed the title Readonly date picker feat(DatePicker): add Readonly date picker Nov 14, 2022
@kodiakhq kodiakhq bot merged commit a95ebe2 into carbon-design-system:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Read-only Inputs]: Datepicker Implementation
4 participants