feat(overflow-menu): add storybook controls #12474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
The flipped boolean doesn't seem to be working for me in the playground. Also not sure why tests are failing? |
|
@alisonjoseph thanks will look into it 🤔 |
|
@aledavila pushed up a change, looks like it was just that the snapshots needed to be updated because you've removed the v11 conditional flag in the export. |
tw15egan
approved these changes
Nov 8, 2022
|
What is the |
alisonjoseph
approved these changes
Nov 10, 2022
alisonjoseph
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12226
Testing / Reviewing
Make sure stories are working as intended
Make sure controls work as intended