Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): update Datatable with Overflow Menu story #12574

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Nov 8, 2022

Closes #12573

Fixes an issue that was causing the OverflowMenu to render incorrectly inside the DataTable storybook examples.

Changelog

Changed

  • Updated OverflowMenuItem to use the itemText prop

Testing / Reviewing

Go to Datatable --> Toolbar --> With Overflow Menu and ensure the OverflowMenu displays correctly.

@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0fc84d5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/636d524e4e0f4400099b5cbf
😎 Deploy Preview https://deploy-preview-12574--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0fc84d5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/636d524ecf7fba000850efff
😎 Deploy Preview https://deploy-preview-12574--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit 7a25103 into carbon-design-system:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: DataTable with Overflow Menu story not rendering properly
3 participants