Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ClickableTile): add test for disabled #13291

Merged
merged 10 commits into from
Mar 17, 2023

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Mar 6, 2023

Closes #12750

*note, RadioTile and ExpandableTile already had tests

Changelog

New

  • add test for disabled prop on ClickableTile
  • fix bug to hide onClick handler for disabled prop on ClickableTile

Testing / Reviewing

yarn test packages/react/src/components/Tile/Tile-test.js

@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 35d0584
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6414708ab7f9c30008b296ff
😎 Deploy Preview https://deploy-preview-13291--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 35d0584
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6414708ace7025000885c225
😎 Deploy Preview https://deploy-preview-13291--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than Francine's comment - looks good to me!

Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! looks like the snapshot might need to be updated @alisonjoseph

@alisonjoseph alisonjoseph requested a review from a team as a code owner March 13, 2023 13:13
@kodiakhq kodiakhq bot merged commit fe45a38 into carbon-design-system:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for tile variants
4 participants