Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(typescript): add TextInputSkeleton types #13314

Merged

Conversation

davesteinberg
Copy link
Contributor

Closes #12562

Convert TextInputSkeleton to TypeScript.

Changelog

Changed

  • TextInput.Skeleton.js converted to tsx, types defined
  • .all-contributorsrc and README.md updated (I'm new!)

Testing / Reviewing

  • Run yarn build; yarn storybook in packages/react. Confirm that the TextInput > Skeleton story works as expected.
  • Add a TextInputSkeleton element to bottom of TextInput.Skeleton.tsx and confirm no type errors. Add a prop with an invalid value and confirm the error is reported.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

DCO Assistant Lite bot All contributors have signed the DCO.

@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7883d0d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/641461e1a5fafd0008951e55
😎 Deploy Preview https://deploy-preview-13314--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7883d0d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/641461e137fa6700086e1bc0
😎 Deploy Preview https://deploy-preview-13314--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@davesteinberg
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀. thanks @davesteinberg !

@kodiakhq kodiakhq bot merged commit d8a6ad4 into carbon-design-system:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to TextInputSkeleton
3 participants