Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(typescript): add TypeScript types to SearchSkeleton #13315

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

davesteinberg
Copy link
Contributor

Closes #12554

Convert SearchSkeleton to TypeScript.

Changelog

Changed

  • Search.Skeleton.js converted to tsx, types defined

Testing / Reviewing

  • Add a SearchSkeleton element to bottom of Search.Skeleton.tsx and confirm no type errors. Add a prop with an invalid value and confirm the error is reported.

@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1a22daf
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/641374c86b2517000822324f
😎 Deploy Preview https://deploy-preview-13315--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 1a22daf
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/641374c8e171e30008f95f95
😎 Deploy Preview https://deploy-preview-13315--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit 70014c9 into carbon-design-system:main Mar 16, 2023
@davesteinberg davesteinberg deleted the ts-search-skeleton branch March 16, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to SearchSkeleton
3 participants