Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radio-button): add validation props #13317

Merged
merged 11 commits into from
Mar 23, 2023

Conversation

aledavila
Copy link
Contributor

Closes #12643

Adds invalid warning and helperText to RadioGroup

Changelog

New

  • adds new validation props to the RadioGroup

Testing / Reviewing

Make sure new props work as expected
Make sure readOnly always takes precedence over other validation props.

@aledavila aledavila requested a review from a team as a code owner March 9, 2023 08:17
@netlify
Copy link

netlify bot commented Mar 9, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c9b09a8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/641b92ade1d294000825cd00
😎 Deploy Preview https://deploy-preview-13317--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 9, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c9b09a8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/641b92adf904480008014ab5
😎 Deploy Preview https://deploy-preview-13317--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aledavila aledavila requested a review from a team as a code owner March 9, 2023 20:16
@alisonjoseph alisonjoseph requested review from a team and aubrey-oneal and removed request for a team March 10, 2023 14:08
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Unrelated to this issue, I did notice that the knobs for the regular story still work and not just the playground, not sure if we want to clean that up here or make a new issue?

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, just took a look at Percy and it seems that there is an extra space now below the radio button group. (yay VRT!)
Screenshot 2023-03-10 at 8 11 30 AM

@aledavila
Copy link
Contributor Author

@alisonjoseph thanks. Yea I can clean that up in this PR. I'll check about the space.

@aledavila
Copy link
Contributor Author

@alisonjoseph updated. ready for review

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 looks good!

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error icon should be using $support-error

image

The error message and icon are also misaligned
image

@kodiakhq kodiakhq bot merged commit d8afeeb into carbon-design-system:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field validation errors: RadioGroup implementation
4 participants