feat(HeaderMenuItem): update prop

[pratikkarad]

Closes #13369

Changelog

Changed

• Added isActive prop
• Deprecated isCurrentPage in HeaderMenuItem

Testing / Reviewing

To verify these changes are working, we can check to see if the existing storybook behavior is still working correctly.

[netlify]

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	e0d84fe
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-components-react/deploys/64182d1d5d024b000868c84e
😎 Deploy Preview	https://deploy-preview-13375--carbon-components-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	e0d84fe
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-elements/deploys/64182d1d9acb2e0008c797a8
😎 Deploy Preview	https://deploy-preview-13375--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	b8e0288
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-components-react/deploys/641b1e101a2a0f0008d58608
😎 Deploy Preview	https://deploy-preview-13375--carbon-components-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	b8e0288
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-elements/deploys/641b1e10d9f09100083121e8
😎 Deploy Preview	https://deploy-preview-13375--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[tay1orjones]

Thanks for this! Just a couple minor things to address

[tay1orjones]

Suggested change

	* @deprecated Please use `isActive`. This will be removed soon in v12.
	* @deprecated Please use `isActive` instead. This will be removed in the next major release.

[tay1orjones]

This needs the deprecate() prop types function helper applied here.

Here's an example of how it's used:

carbon/packages/react/src/components/ComboBox/ComboBox.tsx

Lines 736 to 740 in b0f39f3

	light: deprecate(
	PropTypes.bool,
	'The `light` prop for `Combobox` has ' +
	'been deprecated in favor of the new `Layer` component. It will be removed in the next major release.'
	),

[pratikkarad]

Hey @tay1orjones, I have updated the PR. PTAL, Thanks! 😃

[pratikkarad]

Hi @tay1orjones, as suggested by @tw15egan, I tried doing the same thing to HeaderMenu and updated the test cases but it's still failing for some reason. Any suggestion?

[tw15egan]

LGTM 👍 ✅